From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUbap-0005C7-Pt for qemu-devel@nongnu.org; Tue, 02 Aug 2016 11:26:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUbam-0007vd-0E for qemu-devel@nongnu.org; Tue, 02 Aug 2016 11:26:55 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:17179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUbal-0007vP-Rl for qemu-devel@nongnu.org; Tue, 02 Aug 2016 11:26:51 -0400 Date: Tue, 2 Aug 2016 16:26:44 +0100 From: Anthony PERARD Message-ID: <20160802152644.GU1835@perard.uk.xensource.com> References: <1470140044-16492-1-git-send-email-jgross@suse.com> <1470140044-16492-3-git-send-email-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1470140044-16492-3-git-send-email-jgross@suse.com> Subject: Re: [Qemu-devel] [PATCH v2 2/2] xen: drain submit queue in xen-usb before removing device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juergen Gross Cc: qemu-devel@nongnu.org, xen-devel@lists.xensource.com, kraxel@redhat.com, sstabellini@kernel.org On Tue, Aug 02, 2016 at 02:14:04PM +0200, Juergen Gross wrote: > When unplugging a device in the Xen pvusb backend drain the submit > queue before deallocation of the control structures. Otherwise there > will be bogus memory accesses when I/O contracts are finished. > > Correlated to this issue is the handling of cancel requests: a packet > cancelled will still lead to the call of complete, so add a flag > to the request indicating it should be just dropped on complete. > > Signed-off-by: Juergen Gross Acked-by: Anthony PERARD -- Anthony PERARD