From: David Gibson <david@gibson.dropbear.id.au>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org,
anton@samba.org
Subject: Re: [Qemu-devel] [PATCH v1 1/2] target-ppc: modsw - return 64-bit sign extended
Date: Wed, 3 Aug 2016 11:17:45 +1000 [thread overview]
Message-ID: <20160803011745.GD27583@voom.fritz.box> (raw)
In-Reply-To: <1470124380-5751-1-git-send-email-nikunj@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]
On Tue, Aug 02, 2016 at 01:22:59PM +0530, Nikunj A Dadhania wrote:
> Reported-by: Anton Blanchard <anton@samba.org>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> ---
>
> Can be squashed with the original commit
Done.
>
> target-ppc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index fc3d371..dc89e6a 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -1243,7 +1243,7 @@ static inline void gen_op_arith_modw(DisasContext *ctx, TCGv ret, TCGv arg1,
> tcg_gen_movi_i32(t3, 0);
> tcg_gen_movcond_i32(TCG_COND_NE, t1, t2, t3, t2, t1);
> tcg_gen_rem_i32(t3, t0, t1);
> - tcg_gen_extu_i32_tl(ret, t3);
> + tcg_gen_ext_i32_tl(ret, t3);
> tcg_temp_free_i32(t2);
> tcg_temp_free_i32(t3);
> } else {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-03 2:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 7:52 [Qemu-devel] [PATCH v1 1/2] target-ppc: modsw - return 64-bit sign extended Nikunj A Dadhania
2016-08-02 7:53 ` [Qemu-devel] [PATCH v1 2/2] target-ppc: cmprb - truncate RA to 8bits Nikunj A Dadhania
2016-08-03 1:17 ` David Gibson
2016-08-03 1:17 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803011745.GD27583@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=anton@samba.org \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).