From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUlu8-0002ss-Lc for qemu-devel@nongnu.org; Tue, 02 Aug 2016 22:27:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUlu5-0004aB-Et for qemu-devel@nongnu.org; Tue, 02 Aug 2016 22:27:32 -0400 Date: Wed, 3 Aug 2016 11:17:51 +1000 From: David Gibson Message-ID: <20160803011751.GE27583@voom.fritz.box> References: <1470124380-5751-1-git-send-email-nikunj@linux.vnet.ibm.com> <1470124380-5751-2-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uCPdOCrL+PnN2Vxy" Content-Disposition: inline In-Reply-To: <1470124380-5751-2-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v1 2/2] target-ppc: cmprb - truncate RA to 8bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, anton@samba.org --uCPdOCrL+PnN2Vxy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 02, 2016 at 01:23:00PM +0530, Nikunj A Dadhania wrote: > Missed the following bit in the instruction coding. >=20 > src1 =E2=86=90 EXTZ(RA(56:63)) >=20 > Reported-by: Anton Blanchard > Signed-off-by: Nikunj A Dadhania > --- >=20 > Can be squashed with the original commit Done. >=20 > target-ppc/translate.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index dc89e6a..14f4b68 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -867,6 +867,7 @@ static void gen_cmprb(DisasContext *ctx) > tcg_gen_trunc_tl_i32(src1, cpu_gpr[rA(ctx->opcode)]); > tcg_gen_trunc_tl_i32(src2, cpu_gpr[rB(ctx->opcode)]); > =20 > + tcg_gen_andi_i32(src1, src1, 0xFF); > tcg_gen_ext8u_i32(src2lo, src2); > tcg_gen_shri_i32(src2, src2, 8); > tcg_gen_ext8u_i32(src2hi, src2); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --uCPdOCrL+PnN2Vxy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXoUY/AAoJEGw4ysog2bOS0KMP/2a5lZij/T9uOxKhmtCfoENm 8B2lHN+RCJJTpzYLPtVVa1pBIufziDGuRg2iR/MOnLL7JChxLpsaRwoiYEZkFPGp k+r9uGWl3Oanf/FqLgDPcssQHrM6Dh+U2/7RNyZol00GqZuYLfSx+a5gSEwE7vt3 cbUCe79GWABT0gO5HoOypOIe/D5x/I6szYnNobNqIYUTsgNbY2BBvy48fmNoYvOR Es18nO5f8l/IvMCpCeu7ACveo0gMdZa/BXqqzpfjARD2u2LYBgZT8D4PxvkAz3nO 03yosCs/n79zbDr5v6Np0AVpmwEw+54Cz7aEmA5jw9oC1ZXTjO4npjwUcysZdzWo 064mRglJYG50WbZg9Z/leYNdlSZhRs0FbDWbASGcvqIrdbokkUO58v4asx4hL41N k/qY8DKGDlg1wwsdVOfypcLB2jCRS6QeetVz4IwLRi7mgaHHl0QrCD2suAZEnZXX XzDqZO2vmFgdzy/jg9DQOitEQlXwSTKBP2gChoH+Ta1j/gSqjXx2aZWl4rAMGyUT qncnWu16Y0x7hxtvg1GnZIQfFMRrvLg9/wHzuok741mcbCOEhw7uHJEtCBNWhjxp CZchHMrBwz3Q/VlcL6/n7igW7cij9J+TYUa4xvU4u4Ulf4V86vFgoZ6K4VJSNyO9 ElvwvmDgJk6I708Ubsxx =BSIO -----END PGP SIGNATURE----- --uCPdOCrL+PnN2Vxy--