From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUxBw-0002fg-AO for qemu-devel@nongnu.org; Wed, 03 Aug 2016 10:30:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUxBr-0003je-BH for qemu-devel@nongnu.org; Wed, 03 Aug 2016 10:30:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUxBq-0003jP-TH for qemu-devel@nongnu.org; Wed, 03 Aug 2016 10:30:35 -0400 Date: Wed, 3 Aug 2016 17:30:22 +0300 From: "Michael S. Tsirkin" Message-ID: <20160803172932-mutt-send-email-mst@kernel.org> References: <1470043221-37728-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470043221-37728-1-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH v6 0/2] virtio-crypto: virtio crypto device specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, peter.huangpeng@huawei.com, luonengjun@huawei.com, cornelia.huck@de.ibm.com, stefanha@redhat.com, denglingli@chinamobile.com, Jani.Kokkonen@huawei.com, Ola.Liljedahl@arm.com, Varun.Sethi@freescale.com, xin.zeng@intel.com, brian.a.keating@intel.com, liang.j.ma@intel.com, john.griffin@intel.com, hanweidong@huawei.com, weidong.huang@huawei.com On Mon, Aug 01, 2016 at 05:20:19PM +0800, Gonglei wrote: > This is the specification (version 6) about a new virtio crypto device. > After a big reconstruction, the spec (symmetric algos) is near to stabilize. > This version fix some problems of formating and return value, etc. > > If you have any comments, please let me know, thanks :) You might want to open a jira tracker in oasis jira to add this. > CC: Michael S. Tsirkin > CC: Cornelia Huck > CC: Stefan Hajnoczi > CC: Lingli Deng > CC: Jani Kokkonen > CC: Ola Liljedahl > CC: Varun Sethi > CC: Zeng Xin > CC: Keating Brian > CC: Ma Liang J > CC: Griffin John > CC: Hanweidong > > Changes from v6: > - add conformance clauses for virtio crypto device. [Michael] > - drop VIRTIO_CRYPTO_S_STARTED. [Michael] > - fix some characters problems. [Stefan] > - add a MAC algorithm, named VIRTIO_CRYPTO_MAC_ZUC_EIA3. [Zeng Xin] > - add the fourth return code, named VIRTIO_CRYPTO_OP_INVSESS used > for invalid session id when executing crypto operations. > - drop some gpu stuff forgot to delete. [Michael] > - convert tab to space all over the content. > > Changes from v4: > - introduce crypto services into virtio crypto device. The services > currently defined are CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. > - define a unified crypto request format that is consisted of > general header + service specific request, Where 'general header' is for all > crypto request, 'service specific request' is composed of > operation parameter + input data + output data in generally. > operation parameter is algorithm-specific parameters, > input data is the data should be operated , > output data is the "operation result + result buffer". > - redefine the algorithms and structure based on above crypto services. > - rearrange the title and subtitle > - Only support CIPHER, MAC, HASH and AEAD crypto services, and Xin will > focus KDF, ASYM and PRIMITIVE services. > - Some other corresponding fixes. > - Make a formal patch using tex type. > > This version is a big reconstruction based on Zeng, Xin' comments, thanks a lot. > > Changes from v3: > - Don't use enum is the spec but macros in specific structures. [Michael & Stefan] > - Add two complete structures for session creation and closing, so that > the spec is clear on how to lay out the request. [Stefan] > - Definite the crypto operation request with assigned structure, in this way, > each data request only occupies *one entry* of the Vring descriptor table, > which *improves* the *throughput* of data transferring. > > Changes from v2: > - Reserve virtio device ID 20 for crypto device. [Cornelia] > - Drop all feature bits, those capabilities are offered by the device all the time. [Stefan & Cornelia] > - Add a new section 1.4.2 for driver requirements. [Stefan] > - Use definite type definition instead of enum type in some structure. [Stefan] > - Add virtio_crypto_cipher_alg definition. [Stefan] > - Add a "Device requirements" section as using MUST. [Stefan] > - Some grammar nits fixes and typo fixes. [Stefan & Cornelia] > - Add one VIRTIO_CRYPTO_S_STARTED status for the driver as the flag of virtio-crypto device started and can work now. > > Great thanks for Stefan and Cornelia! > > Changes from v1: > - Drop the feature bit definition for each algorithm, and using config space instead [Cornelia] > - Add multiqueue support and add corresponding feature bit > - Update Encryption process and header definition > - Add session operation process and add corresponding header description > - Other better description in order to fit for virtio spec [Michael] > - Some other trivial fixes. > > > Gonglei (2): > virtio-crypto: Add virtio crypto device specification > virtio-crypto: Add conformance clauses > > conformance.tex | 30 +++ > content.tex | 2 + > virtio-crypto.tex | 793 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 825 insertions(+) > create mode 100644 virtio-crypto.tex > > -- > 1.7.12.4 >