From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bV9ar-0007qG-Fr for qemu-devel@nongnu.org; Wed, 03 Aug 2016 23:45:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bV9an-0000tE-8l for qemu-devel@nongnu.org; Wed, 03 Aug 2016 23:45:12 -0400 Date: Thu, 4 Aug 2016 12:18:15 +1000 From: David Gibson Message-ID: <20160804021815.GD9189@voom.fritz.box> References: <1470224648.12584.97.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FFoLq8A0u+X9iRU8" Content-Disposition: inline In-Reply-To: <1470224648.12584.97.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [PATCH v2] ppc: Stop dumping state on all exceptions in linux-user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: QEMU Developers , "qemu-ppc@nongnu.org" , Anton Blanchard , Peter Maydell --FFoLq8A0u+X9iRU8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 03, 2016 at 09:44:08PM +1000, Benjamin Herrenschmidt wrote: > Other archs don't do it, some programs catch signals just fine > and those dumps just clutter the output. Keep the dumps for cases > that aren't supposed to happen such as unknown codes. >=20 > Signed-off-by: Benjamin Herrenschmidt > --- >=20 > v2. Leave the "XXX" comments alone, we can handle them separately Applied to ppc-for-2.8. >=20 > linux-user/main.c | 12 ------------ > 1 file changed, 12 deletions(-) >=20 > diff --git a/linux-user/main.c b/linux-user/main.c > index eb9975c..860f394 100644 > --- a/linux-user/main.c > +++ b/linux-user/main.c > @@ -1651,8 +1651,6 @@ void cpu_loop(CPUPPCState *env) > "Aborting\n"); > break; > case POWERPC_EXCP_DSI: /* Data storage exception = */ > - EXCP_DUMP(env, "Invalid data memory access: 0x" TARGET_FMT_l= x "\n", > - env->spr[SPR_DAR]); > /* XXX: check this. Seems bugged */ > switch (env->error_code & 0xFF000000) { > case 0x40000000: > @@ -1684,8 +1682,6 @@ void cpu_loop(CPUPPCState *env) > queue_signal(env, info.si_signo, &info); > break; > case POWERPC_EXCP_ISI: /* Instruction storage exception = */ > - EXCP_DUMP(env, "Invalid instruction fetch: 0x\n" TARGET_FMT_= lx > - "\n", env->spr[SPR_SRR0]); > /* XXX: check this */ > switch (env->error_code & 0xFF000000) { > case 0x40000000: > @@ -1716,7 +1712,6 @@ void cpu_loop(CPUPPCState *env) > "Aborting\n"); > break; > case POWERPC_EXCP_ALIGN: /* Alignment exception = */ > - EXCP_DUMP(env, "Unaligned memory access\n"); > /* XXX: check this */ > info.si_signo =3D TARGET_SIGBUS; > info.si_errno =3D 0; > @@ -1729,7 +1724,6 @@ void cpu_loop(CPUPPCState *env) > /* XXX: check this */ > switch (env->error_code & ~0xF) { > case POWERPC_EXCP_FP: > - EXCP_DUMP(env, "Floating point program exception\n"); > info.si_signo =3D TARGET_SIGFPE; > info.si_errno =3D 0; > switch (env->error_code & 0xF) { > @@ -1765,7 +1759,6 @@ void cpu_loop(CPUPPCState *env) > } > break; > case POWERPC_EXCP_INVAL: > - EXCP_DUMP(env, "Invalid instruction\n"); > info.si_signo =3D TARGET_SIGILL; > info.si_errno =3D 0; > switch (env->error_code & 0xF) { > @@ -1789,7 +1782,6 @@ void cpu_loop(CPUPPCState *env) > } > break; > case POWERPC_EXCP_PRIV: > - EXCP_DUMP(env, "Privilege violation\n"); > info.si_signo =3D TARGET_SIGILL; > info.si_errno =3D 0; > switch (env->error_code & 0xF) { > @@ -1819,7 +1811,6 @@ void cpu_loop(CPUPPCState *env) > queue_signal(env, info.si_signo, &info); > break; > case POWERPC_EXCP_FPU: /* Floating-point unavailable except= ion */ > - EXCP_DUMP(env, "No floating point allowed\n"); > info.si_signo =3D TARGET_SIGILL; > info.si_errno =3D 0; > info.si_code =3D TARGET_ILL_COPROC; > @@ -1831,7 +1822,6 @@ void cpu_loop(CPUPPCState *env) > "Aborting\n"); > break; > case POWERPC_EXCP_APU: /* Auxiliary processor unavailable = */ > - EXCP_DUMP(env, "No APU instruction allowed\n"); > info.si_signo =3D TARGET_SIGILL; > info.si_errno =3D 0; > info.si_code =3D TARGET_ILL_COPROC; > @@ -1859,7 +1849,6 @@ void cpu_loop(CPUPPCState *env) > "Aborting\n"); > break; > case POWERPC_EXCP_SPEU: /* SPE/embedded floating-point unava= il. */ > - EXCP_DUMP(env, "No SPE/floating-point instruction allowed\n"= ); > info.si_signo =3D TARGET_SIGILL; > info.si_errno =3D 0; > info.si_code =3D TARGET_ILL_COPROC; > @@ -1923,7 +1912,6 @@ void cpu_loop(CPUPPCState *env) > "while in user mode. Aborting\n"); > break; > case POWERPC_EXCP_VPU: /* Vector unavailable exception = */ > - EXCP_DUMP(env, "No Altivec instructions allowed\n"); > info.si_signo =3D TARGET_SIGILL; > info.si_errno =3D 0; > info.si_code =3D TARGET_ILL_COPROC; >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --FFoLq8A0u+X9iRU8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXoqXnAAoJEGw4ysog2bOSDG4QANpiNJdhKrUgwbREo79bSZLu 0J97mStvpyS7ewdt2KnAGdkZqm6pgebpgXJXJpwG338tmo3Hehq5cB6So0pP9Z+q /Kp0a9mzfDRbB5xlrJJoqet+Tf8dpsQ+t5iJ3DVPOEKGxBKVs2mf5steO5oy1lJf sc3cmOz0d0FMOGOpdAkLdYhWw5zEzdvgCAyuU9hAzDPAhEAO305zwmyJR3zjGmW+ lv0VJFQsgIjZ8WyYHN7T3pqkt9Va0rF6Z3HmIRKc0PG77S9Cq9r0vgcB7jbRjD55 aeDBbinaIxKcHNYYk5Ab6sUFscFILyo8Cr/0BVJQ5jj815OW7KZ/eQWa/TTjhkIY QA56VxtzVhbLMWu6IU4Hrri8Jhb+qgy2FCUiHtTgyOdwO99bSEK3l/gjd76k+SAK eMvi/r3cbB7H+Z+XPlG+/0HSLMz643qfZ4Cx2mEy9DgFXwFQKB0Xj8II/Wt12/D5 7XzWXJf7iLORpB/X0ZEQfEyLjEncNZ1FnGsrMaMhTj0cnIkq9royAn9KbYhgE461 7emxzSouAENWDV8yx/BWJIxemFuHagp8kOEW1FvqMa27b5IR7nzhG2mCOp1R4UHM iGSei1YyzFWivsbIrIZKqsIV/Aco3G5Ojbh5W3pVvN23kNq0JacE0oxRxBs+S+LC YCuNE6+FkhRGQhZcrDNG =yV0A -----END PGP SIGNATURE----- --FFoLq8A0u+X9iRU8--