From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Gu Nini <ngu@redhat.com>, Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.7 v2 0/2] Don't allow burst limits to be lower than the normal limits
Date: Thu, 4 Aug 2016 11:11:41 +0100 [thread overview]
Message-ID: <20160804101141.GH14185@stefanha-x1.localdomain> (raw)
In-Reply-To: <cover.1469693110.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
On Thu, Jul 28, 2016 at 11:08:11AM +0300, Alberto Garcia wrote:
> Hello,
>
> Gu Nini found this problem and reported it in
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1355665
>
> When setting the throttling configuration, the burst limits can be
> lower than the normal limits. This does not making any sense and
> behaves oddly, so let's forbid it.
>
> Berto
>
> v2:
> - Simplify error message [Eric]
>
> Alberto Garcia (2):
> throttle: Don't allow burst limits to be lower than the normal limits
> throttle: Test burst limits lower than the normal limits
>
> tests/test-throttle.c | 8 ++++++++
> util/throttle.c | 5 +++++
> 2 files changed, 13 insertions(+)
>
> --
> 2.8.1
>
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-08-04 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 8:08 [Qemu-devel] [PATCH for-2.7 v2 0/2] Don't allow burst limits to be lower than the normal limits Alberto Garcia
2016-07-28 8:08 ` [Qemu-devel] [PATCH for-2.7 v2 1/2] throttle: " Alberto Garcia
2016-07-28 8:08 ` [Qemu-devel] [PATCH for-2.7 v2 2/2] throttle: Test burst limits " Alberto Garcia
2016-07-28 14:47 ` [Qemu-devel] [PATCH for-2.7 v2 0/2] Don't allow burst limits to be " Eric Blake
2016-08-04 10:11 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804101141.GH14185@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=ngu@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).