From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVFd1-0000v2-10 for qemu-devel@nongnu.org; Thu, 04 Aug 2016 06:11:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVFcz-0003J7-VJ for qemu-devel@nongnu.org; Thu, 04 Aug 2016 06:11:50 -0400 Date: Thu, 4 Aug 2016 11:11:41 +0100 From: Stefan Hajnoczi Message-ID: <20160804101141.GH14185@stefanha-x1.localdomain> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1EKig6ypoSyM7jaD" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH for-2.7 v2 0/2] Don't allow burst limits to be lower than the normal limits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Gu Nini , Eric Blake --1EKig6ypoSyM7jaD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 28, 2016 at 11:08:11AM +0300, Alberto Garcia wrote: > Hello, >=20 > Gu Nini found this problem and reported it in >=20 > https://bugzilla.redhat.com/show_bug.cgi?id=3D1355665 >=20 > When setting the throttling configuration, the burst limits can be > lower than the normal limits. This does not making any sense and > behaves oddly, so let's forbid it. >=20 > Berto >=20 > v2: > - Simplify error message [Eric] >=20 > Alberto Garcia (2): > throttle: Don't allow burst limits to be lower than the normal limits > throttle: Test burst limits lower than the normal limits >=20 > tests/test-throttle.c | 8 ++++++++ > util/throttle.c | 5 +++++ > 2 files changed, 13 insertions(+) >=20 > --=20 > 2.8.1 >=20 Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan --1EKig6ypoSyM7jaD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXoxTdAAoJEJykq7OBq3PIOQIH/0SJ4/4IMPJWFaWIbxEZPpX/ AAUCM114CkuUuxm1NXlA43qDIT06VGcDGJbSPMSYXXf0O0+cASyIITYQh6RzPscV EEs8LwNFfcZ7LW0jIuEGHZeOysqhJzthbE/W3beYDlFOnPB2rx8mSAeXtxjqHQe9 z+GG6X76ODSZWhgXUdbMmJRYMA/tdxNdOBngF1oEXQJlIXH7q3pCcerI29nMGuay R5vHZ0WXKtJk4rM/Cl6V0diID5wxxMPrEcKtITPzThPfITVa1fLqATIcG4M7t0qP TXGUoQnljbNddtj8w3mEaNseoS7at4aoqyKTSGdfy53Q9ADwgftL/59bGj1uRcU= =E4St -----END PGP SIGNATURE----- --1EKig6ypoSyM7jaD--