From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVJK8-0000Zo-6a for qemu-devel@nongnu.org; Thu, 04 Aug 2016 10:08:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVJK2-0007PG-ML for qemu-devel@nongnu.org; Thu, 04 Aug 2016 10:08:34 -0400 Date: Thu, 4 Aug 2016 15:08:20 +0100 From: Anthony PERARD Message-ID: <20160804140820.GA1835@perard.uk.xensource.com> References: <1469633448-10692-1-git-send-email-brogers@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1469633448-10692-1-git-send-email-brogers@suse.com> Subject: Re: [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bruce Rogers Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org, caoj.fnst@cn.fujitsu.com, sstabellini@kernel.org On Wed, Jul 27, 2016 at 09:30:48AM -0600, Bruce Rogers wrote: > Commit 5a11d0f7 mistakenly converted a log message into an error > condition when no pin interrupt is found for the pci device being > passed through. Revert that part of the commit. > > Signed-off-by: Bruce Rogers Acked-by: Anthony PERARD > --- > hw/xen/xen_pt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c > index f593b04..b6d71bb 100644 > --- a/hw/xen/xen_pt.c > +++ b/hw/xen/xen_pt.c > @@ -842,7 +842,7 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) > goto err_out; > } > if (!scratch) { > - error_setg(errp, "no pin interrupt"); > + XEN_PT_LOG(d, "no pin interrupt\n"); > goto out; > } > > -- > 1.9.0 > -- Anthony PERARD