From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] fix incorrect identify implementation in nvme
Date: Thu, 4 Aug 2016 16:14:29 -0400 [thread overview]
Message-ID: <20160804201429.GA6992@localhost.localdomain> (raw)
In-Reply-To: <1470339735-30037-1-git-send-email-hch@lst.de>
On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote:
> Third resent of this series after this didn't get picked up the
> previous times. The Qemu NVMe implementation mistakes the cns
> field in the Identify command as a boolean. This was never
> true, and is actively harmful since NVMe1.1 (which the Qemu
> device claims to support) supports more than two Identify variants.
>
> We had to add a quirk in Linux to work around this behavior.
Yes, these are great. Do we need to ping a maintainer to go through
their tree, or can this be applied immediately? If need be, I can apply
and send a pull request.
next prev parent reply other threads:[~2016-08-04 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 19:42 [Qemu-devel] fix incorrect identify implementation in nvme Christoph Hellwig
2016-08-04 19:42 ` [Qemu-devel] [PATCH 1/2] nvme: fix identify to be NVMe 1.1 compliant Christoph Hellwig
2016-08-04 19:42 ` [Qemu-devel] [PATCH 2/2] nvme: bump PCI revision Christoph Hellwig
2016-08-04 20:14 ` Keith Busch [this message]
2016-08-05 6:48 ` [Qemu-devel] fix incorrect identify implementation in nvme Markus Armbruster
2016-08-05 8:54 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804201429.GA6992@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=hch@lst.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).