From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42035)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <keith.busch@intel.com>) id 1bVOsy-0000pC-6M
	for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:04:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <keith.busch@intel.com>) id 1bVOsv-0003f3-Vk
	for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:04:55 -0400
Date: Thu, 4 Aug 2016 16:14:29 -0400
From: Keith Busch <keith.busch@intel.com>
Message-ID: <20160804201429.GA6992@localhost.localdomain>
References: <1470339735-30037-1-git-send-email-hch@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1470339735-30037-1-git-send-email-hch@lst.de>
Subject: Re: [Qemu-devel] fix incorrect identify implementation in nvme
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org

On Thu, Aug 04, 2016 at 09:42:13PM +0200, Christoph Hellwig wrote:
> Third resent of this series after this didn't get picked up the
> previous times.  The Qemu NVMe implementation mistakes the cns
> field in the Identify command as a boolean.  This was never
> true, and is actively harmful since NVMe1.1 (which the Qemu
> device claims to support) supports more than two Identify variants.
> 
> We had to add a quirk in Linux to work around this behavior.

Yes, these are great. Do we need to ping a maintainer to go through
their tree, or can this be applied immediately? If need be, I can apply
and send a pull request.