From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, eblake@redhat.com, armbru@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.7 v4 06/36] tests: fix test-cutils leaks
Date: Fri, 5 Aug 2016 12:23:51 +0400 [thread overview]
Message-ID: <20160805082421.21994-7-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20160805082421.21994-1-marcandre.lureau@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Spotted thanks to ASAN.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
tests/test-cutils.c | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/tests/test-cutils.c b/tests/test-cutils.c
index 64e3e95..20b0f59 100644
--- a/tests/test-cutils.c
+++ b/tests/test-cutils.c
@@ -378,7 +378,7 @@ static void test_qemu_strtol_hex(void)
static void test_qemu_strtol_max(void)
{
- const char *str = g_strdup_printf("%ld", LONG_MAX);
+ char *str = g_strdup_printf("%ld", LONG_MAX);
char f = 'X';
const char *endptr = &f;
long res = 999;
@@ -389,6 +389,7 @@ static void test_qemu_strtol_max(void)
g_assert_cmpint(err, ==, 0);
g_assert_cmpint(res, ==, LONG_MAX);
g_assert(endptr == str + strlen(str));
+ g_free(str);
}
static void test_qemu_strtol_overflow(void)
@@ -497,7 +498,7 @@ static void test_qemu_strtol_full_trailing(void)
static void test_qemu_strtol_full_max(void)
{
- const char *str = g_strdup_printf("%ld", LONG_MAX);
+ char *str = g_strdup_printf("%ld", LONG_MAX);
long res;
int err;
@@ -505,6 +506,7 @@ static void test_qemu_strtol_full_max(void)
g_assert_cmpint(err, ==, 0);
g_assert_cmpint(res, ==, LONG_MAX);
+ g_free(str);
}
static void test_qemu_strtoul_correct(void)
@@ -662,7 +664,7 @@ static void test_qemu_strtoul_hex(void)
static void test_qemu_strtoul_max(void)
{
- const char *str = g_strdup_printf("%lu", ULONG_MAX);
+ char *str = g_strdup_printf("%lu", ULONG_MAX);
char f = 'X';
const char *endptr = &f;
unsigned long res = 999;
@@ -673,6 +675,7 @@ static void test_qemu_strtoul_max(void)
g_assert_cmpint(err, ==, 0);
g_assert_cmpint(res, ==, ULONG_MAX);
g_assert(endptr == str + strlen(str));
+ g_free(str);
}
static void test_qemu_strtoul_overflow(void)
@@ -776,7 +779,7 @@ static void test_qemu_strtoul_full_trailing(void)
static void test_qemu_strtoul_full_max(void)
{
- const char *str = g_strdup_printf("%lu", ULONG_MAX);
+ char *str = g_strdup_printf("%lu", ULONG_MAX);
unsigned long res = 999;
int err;
@@ -784,6 +787,7 @@ static void test_qemu_strtoul_full_max(void)
g_assert_cmpint(err, ==, 0);
g_assert_cmpint(res, ==, ULONG_MAX);
+ g_free(str);
}
static void test_qemu_strtoll_correct(void)
@@ -941,7 +945,7 @@ static void test_qemu_strtoll_hex(void)
static void test_qemu_strtoll_max(void)
{
- const char *str = g_strdup_printf("%lld", LLONG_MAX);
+ char *str = g_strdup_printf("%lld", LLONG_MAX);
char f = 'X';
const char *endptr = &f;
int64_t res = 999;
@@ -952,6 +956,7 @@ static void test_qemu_strtoll_max(void)
g_assert_cmpint(err, ==, 0);
g_assert_cmpint(res, ==, LLONG_MAX);
g_assert(endptr == str + strlen(str));
+ g_free(str);
}
static void test_qemu_strtoll_overflow(void)
@@ -1058,7 +1063,7 @@ static void test_qemu_strtoll_full_trailing(void)
static void test_qemu_strtoll_full_max(void)
{
- const char *str = g_strdup_printf("%lld", LLONG_MAX);
+ char *str = g_strdup_printf("%lld", LLONG_MAX);
int64_t res;
int err;
@@ -1066,6 +1071,7 @@ static void test_qemu_strtoll_full_max(void)
g_assert_cmpint(err, ==, 0);
g_assert_cmpint(res, ==, LLONG_MAX);
+ g_free(str);
}
static void test_qemu_strtoull_correct(void)
@@ -1223,7 +1229,7 @@ static void test_qemu_strtoull_hex(void)
static void test_qemu_strtoull_max(void)
{
- const char *str = g_strdup_printf("%llu", ULLONG_MAX);
+ char *str = g_strdup_printf("%llu", ULLONG_MAX);
char f = 'X';
const char *endptr = &f;
uint64_t res = 999;
@@ -1234,6 +1240,7 @@ static void test_qemu_strtoull_max(void)
g_assert_cmpint(err, ==, 0);
g_assert_cmpint(res, ==, ULLONG_MAX);
g_assert(endptr == str + strlen(str));
+ g_free(str);
}
static void test_qemu_strtoull_overflow(void)
@@ -1339,7 +1346,7 @@ static void test_qemu_strtoull_full_trailing(void)
static void test_qemu_strtoull_full_max(void)
{
- const char *str = g_strdup_printf("%lld", ULLONG_MAX);
+ char *str = g_strdup_printf("%lld", ULLONG_MAX);
uint64_t res = 999;
int err;
@@ -1347,6 +1354,7 @@ static void test_qemu_strtoull_full_max(void)
g_assert_cmpint(err, ==, 0);
g_assert_cmpint(res, ==, ULLONG_MAX);
+ g_free(str);
}
static void test_qemu_strtosz_simple(void)
--
2.9.0
next prev parent reply other threads:[~2016-08-05 8:24 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 8:23 [Qemu-devel] [PATCH for-2.7 v4 00/36] Various memory leak fixes marcandre.lureau
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 01/36] build-sys: fix building with make CFLAGS=.. argument marcandre.lureau
2016-08-08 8:58 ` Paolo Bonzini
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 02/36] tests: fix test-qga leaks marcandre.lureau
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 03/36] glib-compat: add g_(s)list_free_full() marcandre.lureau
2016-08-05 11:25 ` Markus Armbruster
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 04/36] qga: free the whole blacklist marcandre.lureau
2016-08-05 11:25 ` Markus Armbruster
2016-08-05 16:57 ` Eric Blake
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 05/36] qga: free remaining leaking state marcandre.lureau
2016-08-05 11:26 ` Markus Armbruster
2016-08-05 16:56 ` Eric Blake
2016-08-05 8:23 ` marcandre.lureau [this message]
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 07/36] tests: fix test-vmstate leaks marcandre.lureau
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 08/36] tests: fix test-iov leaks marcandre.lureau
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 09/36] tests: fix check-qom-interface leaks marcandre.lureau
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 10/36] tests: fix check-qom-proplist leaks marcandre.lureau
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 11/36] tests: fix small leak in test-io-channel-command marcandre.lureau
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 12/36] tests: fix leak in test-string-input-visitor marcandre.lureau
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 13/36] portio: keep references on portio marcandre.lureau
2016-08-05 8:23 ` [Qemu-devel] [PATCH for-2.7 v4 14/36] numa: do not leak NumaOptions marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 15/36] pc: simplify passing qemu_irq marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 16/36] pc: don't leak a20_line marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 17/36] machine: use class base init generated name marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 18/36] acpi-build: fix array leak marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 19/36] char: free the tcp connection data when closing marcandre.lureau
2016-08-05 10:04 ` Paolo Bonzini
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 20/36] char: free MuxDriver " marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 21/36] tests: fix qom-test leaks marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 22/36] pc: free i8259 marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 23/36] pc: keep gsi reference marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 24/36] ahci: free irqs array marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 25/36] sd: free timer marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 26/36] qjson: free str marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 27/36] virtio-input: free config list marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 28/36] ipmi: free extern timer marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 29/36] usb: free USBDevice.strings marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 30/36] usb: free leaking path marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 31/36] bus: simplify name handling marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 32/36] tests: add qtest_add_data_func_full marcandre.lureau
2016-08-05 11:29 ` Markus Armbruster
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 33/36] tests: pc-cpu-test leaks fixes marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 34/36] tests: fix rsp leak in postcopy-test marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 35/36] ahci: fix sglist leak on retry marcandre.lureau
2016-08-05 8:24 ` [Qemu-devel] [PATCH for-2.7 v4 36/36] tests: fix postcopy-test leaks marcandre.lureau
2016-08-05 8:40 ` [Qemu-devel] [PATCH for-2.7 v4 00/36] Various memory leak fixes Daniel P. Berrange
2016-08-05 18:01 ` Marc-André Lureau
2016-08-07 19:15 ` Peter Maydell
2016-08-07 19:31 ` Marc-André Lureau
2016-08-07 19:38 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805082421.21994-7-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).