From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWD5m-0002Hw-Ky for qemu-devel@nongnu.org; Sat, 06 Aug 2016 21:41:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWD5h-00022P-M2 for qemu-devel@nongnu.org; Sat, 06 Aug 2016 21:41:29 -0400 Received: from mail-yw0-x242.google.com ([2607:f8b0:4002:c05::242]:33745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWD5h-00021t-HH for qemu-devel@nongnu.org; Sat, 06 Aug 2016 21:41:25 -0400 Received: by mail-yw0-x242.google.com with SMTP id z8so23273008ywa.0 for ; Sat, 06 Aug 2016 18:41:23 -0700 (PDT) From: Pranith Kumar Date: Sat, 6 Aug 2016 21:41:21 -0400 Message-Id: <20160807014121.18739-1-bobby.prani@gmail.com> Subject: [Qemu-devel] [PATCH 1/1] seqlock: Fix warning reg. incompatible cast List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , "Emilio G. Cota" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Sergey Fedorov , Markus Armbruster , "open list:All patches CC here" With the latest clang, we have the following warning. We are not using the const qualifier consistently in other functions. So remove it from the only one that uses it to fix the warning. /home/pranith/devops/code/qemu/include/qemu/seqlock.h:62:21: warning: passing 'typeof (*&sl->sequence) *' (aka 'const unsigned int *') to parameter of type 'unsigned int *' discards qualifier s [-Wincompatible-pointer-types-discards-qualifiers] return unlikely(atomic_read(&sl->sequence) != start); ^~~~~~~~~~~~~~~~~~~~~~~~~~ /home/pranith/devops/code/qemu/include/qemu/atomic.h:58:25: note: expanded from macro 'atomic_read' __atomic_load(ptr, &_val, __ATOMIC_RELAXED); \ ^~~~~ /home/pranith/devops/code/qemu/include/qemu/compiler.h:62:43: note: expanded from macro 'unlikely' #define unlikely(x) __builtin_expect(!!(x), 0) Signed-off-by: Pranith Kumar --- include/qemu/seqlock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qemu/seqlock.h b/include/qemu/seqlock.h index 2e2be4c..aa4cf15 100644 --- a/include/qemu/seqlock.h +++ b/include/qemu/seqlock.h @@ -55,7 +55,7 @@ static inline unsigned seqlock_read_begin(QemuSeqLock *sl) return ret & ~1; } -static inline int seqlock_read_retry(const QemuSeqLock *sl, unsigned start) +static inline int seqlock_read_retry(QemuSeqLock *sl, unsigned start) { /* Read other fields before reading final sequence. */ smp_rmb(); -- 2.9.2