From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWgO1-0000i6-GR for qemu-devel@nongnu.org; Mon, 08 Aug 2016 04:58:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWgO0-0006TZ-Aa for qemu-devel@nongnu.org; Mon, 08 Aug 2016 04:58:17 -0400 Date: Mon, 8 Aug 2016 09:58:02 +0100 From: "Daniel P. Berrange" Message-ID: <20160808085802.GC20826@redhat.com> Reply-To: "Daniel P. Berrange" References: <1470636568-8291-1-git-send-email-famz@redhat.com> <1470636568-8291-3-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1470636568-8291-3-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/8] tests: Add uuid tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com, mreitz@redhat.com, mdroth@linux.vnet.ibm.com, armbru@redhat.com, sw@weilnetz.de, qemu-block@nongnu.org, jcody@redhat.com On Mon, Aug 08, 2016 at 02:09:22PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/Makefile.include | 2 + > tests/test-uuid.c | 110 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 112 insertions(+) > create mode 100644 tests/test-uuid.c > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index ebecfa4..d46f3a5 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -111,6 +111,7 @@ check-unit-y += tests/test-crypto-xts$(EXESUF) > check-unit-y += tests/test-crypto-block$(EXESUF) > gcov-files-test-logging-y = tests/test-logging.c > check-unit-y += tests/test-logging$(EXESUF) > +check-unit-y += tests/test-uuid$(EXESUF) > > check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh > > @@ -629,6 +630,7 @@ tests/test-filter-mirror$(EXESUF): tests/test-filter-mirror.o $(qtest-obj-y) > tests/test-filter-redirector$(EXESUF): tests/test-filter-redirector.o $(qtest-obj-y) > tests/ivshmem-test$(EXESUF): tests/ivshmem-test.o contrib/ivshmem-server/ivshmem-server.o $(libqos-pc-obj-y) > tests/vhost-user-bridge$(EXESUF): tests/vhost-user-bridge.o > +tests/test-uuid$(EXESUF): tests/test-uuid.o $(test-util-obj-y) > > tests/migration/stress$(EXESUF): tests/migration/stress.o > $(call quiet-command, $(LINKPROG) -static -O3 $(PTHREAD_LIB) -o $@ $< ," LINK $(TARGET_DIR)$@") > diff --git a/tests/test-uuid.c b/tests/test-uuid.c > new file mode 100644 > index 0000000..05a40fd > --- /dev/null > +++ b/tests/test-uuid.c > @@ -0,0 +1,110 @@ > +/* > + * QEMU UUID Library > + * > + * Copyright (c) 2016 Red Hat, Inc. > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, see . > + * > + */ > + > +#include "qemu/osdep.h" > +#include "qemu/uuid.h" > + > +struct { const char *uuidstr; QemuUUID uuid; } uuid_test_data[] = { > + { > + "586ece27-7f09-41e0-9e74-e901317e9d42", > + {0x58, 0x6e, 0xce, 0x27, 0x7f, 0x09, 0x41, 0xe0, > + 0x9e, 0x74, 0xe9, 0x01, 0x31, 0x7e, 0x9d, 0x42}, > + }, { > + "0cc6c752-3961-4028-a286-c05cc616d396", Use uppercase A-F in this one, so we're got a pair of uuids which cover both cases > + {0x0c, 0xc6, 0xc7, 0x52, 0x39, 0x61, 0x40, 0x28, > + 0xa2, 0x86, 0xc0, 0x5c, 0xc6, 0x16, 0xd3, 0x96} > + }, { > + "00000000-0000-0000-0000-000000000000", > + { 0 }, > + } We should do some negative tests. eg a uuid without '-' separators; a UUID which is too short; a UUID which is too long; a UUID which has non-hex characters, a zero length UUID. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|