From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWkCj-0004e7-OE for qemu-devel@nongnu.org; Mon, 08 Aug 2016 09:03:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWkCi-0003bS-G5 for qemu-devel@nongnu.org; Mon, 08 Aug 2016 09:02:53 -0400 Date: Mon, 8 Aug 2016 14:02:44 +0100 From: Stefan Hajnoczi Message-ID: <20160808130244.GH30105@stefanha-x1.localdomain> References: <1469175475-15420-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4C6bbPZ6c/S1npyF" Content-Disposition: inline In-Reply-To: <1469175475-15420-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH v7 00/16] backup compression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Kevin Wolf , Pavel Butsykin , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow --4C6bbPZ6c/S1npyF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 22, 2016 at 11:17:39AM +0300, Denis V. Lunev wrote: > The idea is simple - backup is "written-once" data. It is written block > by block and it is large enough. It would be nice to save storage > space and compress it. >=20 > These patches add the ability to compress data during backup. This > functionality is implemented by means of adding options to the qmp/hmp > commands(drive-backup, blockdev-backup). The implementation is quite > simple, because the responsibility for data compression imposed on the > format driver. >=20 > Changes from v1: > - added unittest for backup compression (12, 13) >=20 > Changes from v2: > - implemented a new .bdrv_co_write_compressed interface to replace the > old .bdrv_write_compressed (2,3,4,5,6) >=20 > Changes from v3: > - added the byte-based interfaces: > blk_pwrite_compressed()/blk_co_pwritev_compressed() (1, 7) > - fix drive/blockdev-backup documentation (10, 11) >=20 > Changes from v4: > - added assert that offset and count are aligned (1) > - reuse RwCo and bdrv_co_pwritev() for write compressed (2) > - converted interfaces to byte-based for format drivers (2, 3, 5, 6) > - move an unrelated cleanup in a separate patches (4, 7) > - turn on dirty_bitmaps for the compressed writes (9) > - added simplify drive/blockdev-backup by using the boxed commands (10, 1= 1) > - reworded drive/blockdev-backup documentation about compression (12, 13) > - fix s/bakup/backup/ (14) >=20 > Changes from v5: > - rebased on master > - fix grammar (5, 8) >=20 > Changes from v6: > - more grammar fixes (1,11) > - assignment cleanup as suggested by Eric in 11 >=20 > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Markus Armbruster > CC: Eric Blake > CC: John Snow > CC: Stefan Hajnoczi > CC: Kevin Wolf >=20 > Pavel Butsykin (16): > block: switch blk_write_compressed() to byte-based interface > block: Convert bdrv_pwrite_compressed() to BdrvChild > block/io: reuse bdrv_co_pwritev() for write compressed > qcow2: add qcow2_co_pwritev_compressed > qcow2: cleanup qcow2_co_pwritev_compressed to avoid the recursion > vmdk: add vmdk_co_pwritev_compressed > qcow: add qcow_co_pwritev_compressed > qcow: cleanup qcow_co_pwritev_compressed to avoid the recursion > block: remove BlockDriver.bdrv_write_compressed > block/io: turn on dirty_bitmaps for the compressed writes > block: simplify drive-backup > block: simplify blockdev-backup > drive-backup: added support for data compression > blockdev-backup: added support for data compression > qemu-iotests: test backup compression in 055 > qemu-iotests: add vmdk for test backup compression in 055 >=20 > block/backup.c | 12 ++- > block/block-backend.c | 27 +----- > block/io.c | 48 ++++------ > block/qcow.c | 113 +++++++++--------------- > block/qcow2.c | 128 ++++++++++----------------- > block/vmdk.c | 55 ++---------- > blockdev.c | 193 ++++++++++++++---------------------= ------ > hmp-commands.hx | 8 +- > hmp.c | 24 ++--- > include/block/block.h | 5 +- > include/block/block_int.h | 5 +- > include/sysemu/block-backend.h | 4 +- > qapi/block-core.json | 18 +++- > qemu-img.c | 8 +- > qemu-io-cmds.c | 2 +- > qmp-commands.hx | 9 +- > tests/qemu-iotests/055 | 118 +++++++++++++++++++++++++ > tests/qemu-iotests/055.out | 4 +- > tests/qemu-iotests/iotests.py | 10 +-- > 19 files changed, 366 insertions(+), 425 deletions(-) >=20 > --=20 > 2.1.4 >=20 >=20 Since no one else has applied this... Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan --4C6bbPZ6c/S1npyF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXqILzAAoJEJykq7OBq3PI0nAH/3n0J5+ixb4KmT3lVUr+of// X2XAcC6U07XVlO3JQ97NkxELJPBut48vZz1nxscon6y7X6DCWrOeF5aaWk7yLtMQ uVR8M1gr6ZOMQl0KX1AIoiMrPIZ7IwaLIZyyyEj9wc04JBcoGXRpceng0bgpLZwK tw6o0oBjqeG+l9/CU1/cUN1QvBkwQx6mmDzL08e2k2oERX5ihWfvN2Xz6J5w+Ibn QDAMT66oKVB54UOJ+ogANQk3go+HzWUhaThXzW1lvqWBmPhibDJb0hYTzf4Urn45 Z7GDUb8UMae6d0hOF16k/a8+or/TNPx6cJdqoJOuxoDhpVmc/8V6NctlJUC57Os= =tQsH -----END PGP SIGNATURE----- --4C6bbPZ6c/S1npyF--