From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46956)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bWlGA-0002PQ-If
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 10:10:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1bWlG8-0004QD-Fe
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 10:10:29 -0400
Date: Mon, 8 Aug 2016 16:10:14 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160808141014.GE25992@noname.str.redhat.com>
References: <1469175475-15420-1-git-send-email-den@openvz.org>
	<1469175475-15420-14-git-send-email-den@openvz.org>
	<20160808140743.GD25992@noname.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160808140743.GD25992@noname.str.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7 13/16] drive-backup: added support for
 data compression
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Pavel Butsykin <pbutsykin@virtuozzo.com>, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, Eric Blake <eblake@redhat.com>, John Snow <jsnow@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Am 08.08.2016 um 16:07 hat Kevin Wolf geschrieben:
> Am 22.07.2016 um 10:17 hat Denis V. Lunev geschrieben:
> > @@ -3317,7 +3320,7 @@ void do_blockdev_backup(BlockdevBackup *backup, BlockJobTxn *txn, Error **errp)
> >          }
> >      }
> >      backup_start(backup->job_id, bs, target_bs, backup->speed, backup->sync,
> > -                 NULL, backup->on_source_error, backup->on_target_error,
> > +                 NULL, false, backup->on_source_error, backup->on_target_error,
> >                   block_job_cb, bs, txn, &local_err);
> >      if (local_err != NULL) {
> >          error_propagate(errp, local_err);
> 
> blockdev-backup is supposed to be the primary interface in the future,
> so I would like to avoid introducing a feature gap where drive-backup is
> more powerful. Can you please post a small diff to squash in so that
> this patch adds the option to both commands? Wiring this up should be
> trivial.

Never mind, you already do. Somehow I didn't expect it in a separate
patch. The series is fine as it is. :-)

Kevin