From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45981)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bWmM9-0004z5-TL
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 11:20:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bWmM2-0008KW-S9
	for qemu-devel@nongnu.org; Mon, 08 Aug 2016 11:20:42 -0400
Date: Mon, 8 Aug 2016 16:20:35 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20160808152035.GF25553@stefanha-x1.localdomain>
References: <1470147137-21970-1-git-send-email-clord@redhat.com>
	<1470147137-21970-3-git-send-email-clord@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="s5/bjXLgkIwAv6Hi"
Content-Disposition: inline
In-Reply-To: <1470147137-21970-3-git-send-email-clord@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v6 2/4] blockdev: Add dynamic
 generation of module_block.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Colin Lord <clord@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, Marc Mari <markmb@redhat.com>, qemu-block@nongnu.org, mreitz@redhat.com


--s5/bjXLgkIwAv6Hi
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 02, 2016 at 10:12:15AM -0400, Colin Lord wrote:
> From: Marc Mari <markmb@redhat.com>
>=20
> To simplify the addition of new block modules, add a script that generates
> module_block.h automatically from the modules' source code.
>=20
> This script assumes that the QEMU coding style rules are followed.
>=20
> Signed-off-by: Marc Mar=ED <markmb@redhat.com>
> Signed-off-by: Colin Lord <clord@redhat.com>
> ---
>  Makefile                        |   7 +++
>  scripts/modules/module_block.py | 108 ++++++++++++++++++++++++++++++++++=
++++++
>  2 files changed, 115 insertions(+)
>  create mode 100644 scripts/modules/module_block.py

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--s5/bjXLgkIwAv6Hi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJXqKNDAAoJEJykq7OBq3PIT+0H/3JG1k9nPeIEVNCdFYHPl0HT
GlJjlEW2Rf9DglW9moz4AM832s0jDz7ll8IpsB7bkZOundqifsvP0+S8wlpr7fpc
Ng3ZQ9SAivb6sh3DMfDljYbjUrbFLKmcB9nMmSWScZooaJ3uVGeBENhdcY1HN15i
HNOfnOdeIIBBETJ79l9ADU7ICXR6SD+eVLtffGPaqIAhUXdsuAHXqlcPcCDS39Fk
N337NCGTsjkGtkOyRj7jxZLClP6uGD5Cds6nPoW0uFylL4fLsDkfuSWHH7JYkeCE
krm2xDnvkxNN5DsyWPnR5Su6s0JkXB0WbRTeL+3zVbS/IxU/4cBQB4toeYRBLw4=
=bdNl
-----END PGP SIGNATURE-----

--s5/bjXLgkIwAv6Hi--