Re: [Qemu-devel] [PATCH] add migration capability to bypass the shared memory

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1470744604-80857-1-git-send-email-jiangshanlai@gmail.com
Type: series
Subject: [Qemu-devel] [PATCH] add migration capability to bypass the shared memory

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e63cdc7 add migration capability to bypass the shared memory

=== OUTPUT BEGIN ===
Checking PATCH 1/1: add migration capability to bypass the shared memory...
ERROR: code indent should never use tabs
#175: FILE: migration/ram.c:626:
+^I    migration_dirty_pages += block->used_length >> TARGET_PAGE_BITS;$

ERROR: code indent should never use tabs
#176: FILE: migration/ram.c:627:
+^I}$

ERROR: code indent should never use tabs
#204: FILE: migration/ram.c:1958:
+^I^I    migration_bitmap_rcu->bmap, ram_bitmap_pages);$

total: 3 errors, 0 warnings, 137 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org