Re: [Qemu-devel] [RFC 0/2] Explicit SID for IOAPIC

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1470753137-18354-1-git-send-email-davidkiarie4@gmail.com
Type: series
Subject: [Qemu-devel] [RFC 0/2] Explicit SID for IOAPIC

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6e2b4d6 hw/i386: enforce SID verification
1ce4c7d hw/msi: Allow platform devices to use explicit SID

=== OUTPUT BEGIN ===
Checking PATCH 1/2: hw/msi: Allow platform devices to use explicit SID...
WARNING: line over 80 characters
#69: FILE: hw/intc/ioapic.c:98:
+static void ioapic_write_ioapic_as(IOAPICCommonState *s, uint32_t data, uint64_t addr)

WARNING: line over 80 characters
#249: FILE: include/sysemu/kvm.h:494:
+int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev, uint16_t requester_id);

WARNING: line over 80 characters
#265: FILE: kvm-all.c:1249:
+int kvm_irqchip_add_msi_route(KVMState *s, int vector, PCIDevice *dev, uint16_t requester_id)

total: 0 errors, 3 warnings, 274 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/2: hw/i386: enforce SID verification...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org