From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38176) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX8oT-00070d-Qm for qemu-devel@nongnu.org; Tue, 09 Aug 2016 11:19:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX8oP-0002F3-Im for qemu-devel@nongnu.org; Tue, 09 Aug 2016 11:19:28 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:44601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX8oP-00029y-EK for qemu-devel@nongnu.org; Tue, 09 Aug 2016 11:19:25 -0400 Date: Tue, 9 Aug 2016 16:19:12 +0100 From: Anthony PERARD Message-ID: <20160809151912.GC1835@perard.uk.xensource.com> References: <1470042985-680-1-git-send-email-paul.durrant@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1470042985-680-1-git-send-email-paul.durrant@citrix.com> Subject: Re: [Qemu-devel] [PATCH] xen: handle inbound migration of VMs without ioreq server pages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Durrant Cc: xen-devel@lists.xenproject.org, qemu-devel@nongnu.org, Stefano Stabellini On Mon, Aug 01, 2016 at 10:16:25AM +0100, Paul Durrant wrote: > VMs created on older versions on Xen will not have been provisioned with > pages to support creation of non-default ioreq servers. In this case > the ioreq server API is not supported and QEMU's only option is to fall > back to using the default ioreq server pages as it did prior to > commit 3996e85c ("Xen: Use the ioreq-server API when available"). > > This patch therefore changes the code in xen_common.h to stop considering > a failure of xc_hvm_create_ioreq_server() as a hard failure but simply > as an indication that the guest is too old to support the ioreq server > API. Instead a boolean is set to cause reversion to old behaviour such > that the default ioreq server is then used. > > Signed-off-by: Paul Durrant > Cc: Stefano Stabellini > Cc: Anthony Perard There are just two lines too long: WARNING: line over 80 characters #31: FILE: include/hw/xen/xen_common.h:110: +static inline int xen_get_default_ioreq_server_info(xc_interface *xc, domid_t dom, WARNING: line over 80 characters #34: FILE: include/hw/xen/xen_common.h:113: + evtchn_port_t *bufioreq_evtchn) With that fixed: Acked-by: Anthony PERARD Thanks, -- Anthony PERARD