From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9Yf-0001S8-9H for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:07:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX9Yb-0006M6-0j for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:07:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9Ya-0006M0-OR for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:07:08 -0400 Date: Tue, 9 Aug 2016 18:07:04 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Message-ID: <20160809160703.GA10637@potion> References: <20160809150333.9991-1-rkrcmar@redhat.com> <20160809153149.131721.2006@ex-std-node742.prod.rhcloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160809153149.131721.2006@ex-std-node742.prod.rhcloud.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] checkpatch: allow tabs in linux-headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: no-reply@ec2-52-6-146-230.compute-1.amazonaws.com Cc: famz@redhat.com, ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com, jan.kiszka@web.de, pbonzini@redhat.com, rth@twiddle.net 2016-08-09 08:31-0700, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com: > Hi, >=20 > Your series seems to have some coding style problems. See output below = for > more information: >=20 > Message-id: 20160809150333.9991-1-rkrcmar@redhat.com > Type: series > Subject: [Qemu-devel] [PATCH for-2.7 0/2] intel-iommu: restrict EIM to = quirkless KVM >=20 > =3D=3D=3D TEST SCRIPT BEGIN =3D=3D=3D > #!/bin/bash >=20 > BASE=3Dbase > n=3D1 > total=3D$(git log --oneline $BASE.. | wc -l) > failed=3D0 >=20 > commits=3D"$(git log --format=3D%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=3D%s= $c)..." > if ! git show $c --format=3Demail | ./scripts/checkpatch.pl --mailb= ack -; then > failed=3D1 > echo > fi > n=3D$((n+1)) > done >=20 > exit $failed > =3D=3D=3D TEST SCRIPT END =3D=3D=3D >=20 > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > e018fb0 intel-iommu: restrict EIM to quirkless KVM > 5ef6f2f linux-headers: update to v4.8-rc1 >=20 > =3D=3D=3D OUTPUT BEGIN =3D=3D=3D > Checking PATCH 1/2: linux-headers: update to v4.8-rc1... > ERROR: code indent should never use tabs > #32: FILE: linux-headers/linux/kvm.h:885: > +^Iunion {$ >=20 > ERROR: code indent should never use tabs > #33: FILE: linux-headers/linux/kvm.h:886: > +^I^I__u32 pad;$ >=20 > ERROR: code indent should never use tabs > #34: FILE: linux-headers/linux/kvm.h:887: > +^I^I__u32 devid;$ >=20 > ERROR: code indent should never use tabs > #35: FILE: linux-headers/linux/kvm.h:888: > +^I};$ >=20 > ERROR: code indent should never use tabs > #43: FILE: linux-headers/linux/kvm.h:1034: > +#define KVM_MSI_VALID_DEVID^I(1U << 0)$ >=20 > ERROR: code indent should never use tabs > #50: FILE: linux-headers/linux/kvm.h:1040: > +^I__u32 devid;$ >=20 > ERROR: code indent should never use tabs > #51: FILE: linux-headers/linux/kvm.h:1041: > +^I__u8 pad[12];$ >=20 > ERROR: code indent should never use tabs > #59: FILE: linux-headers/linux/kvm.h:1086: > +^IKVM_DEV_TYPE_ARM_VGIC_ITS,$ >=20 > ERROR: code indent should never use tabs > #60: FILE: linux-headers/linux/kvm.h:1087: > +#define KVM_DEV_TYPE_ARM_VGIC_ITS^IKVM_DEV_TYPE_ARM_VGIC_ITS$ >=20 > total: 9 errors, 0 warnings, 51 lines checked >=20 > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. These indentation errors are false positives. ---8<--- Make scripts/checkpatch.pl accept tabs in linux-headers/, instead of changing scripts/update-linux-headers.sh to expand tabs when importing. Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 --- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 929708721299..38232d4b25c3 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1355,7 +1355,7 @@ sub process { next if ($realfile !~ /\.(h|c|cpp|pl)$/); =20 # in QEMU, no tabs are allowed - if ($rawline =3D~ /^\+.*\t/) { + if ($rawline =3D~ /^\+.*\t/ && $realfile !~ /^linux-headers\//) { my $herevet =3D "$here\n" . cat_vet($rawline) . "\n"; ERROR("code indent should never use tabs\n" . $herevet); $rpt_cleaners =3D 1;