From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9jU-0005gB-AZ for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:18:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX9jR-0000Bm-2j for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:18:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9jQ-0000Bi-T5 for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:18:21 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 67252C07D8CA for ; Tue, 9 Aug 2016 16:18:20 +0000 (UTC) Date: Tue, 9 Aug 2016 17:18:17 +0100 From: "Daniel P. Berrange" Message-ID: <20160809161817.GL1530@redhat.com> Reply-To: "Daniel P. Berrange" References: <1470756748-18933-1-git-send-email-berrange@redhat.com> <1470756748-18933-9-git-send-email-berrange@redhat.com> <426f9bff-4bff-3b80-e236-1cde6c3ab423@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <426f9bff-4bff-3b80-e236-1cde6c3ab423@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.8 v1 08/60] trace: provide mechanism for registering trace events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On Tue, Aug 09, 2016 at 06:17:04PM +0200, Paolo Bonzini wrote: > > > On 09/08/2016 17:31, Daniel P. Berrange wrote: > > + out('void trace_register_events(void)', > > + '{', > > + ' trace_event_register_group(trace_events, TRACE_EVENT_COUNT);', > > + '}', > > + 'trace_init(trace_register_events)') > > Should this function be static? Yes it should be actually - left over from before I was using the qemu-module support to register these. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|