qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, thuth@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] checkpatch: tweak the files in which TABs are checked
Date: Wed, 10 Aug 2016 10:06:41 +0800	[thread overview]
Message-ID: <20160810020641.GF11351@al.usersys.redhat.com> (raw)
In-Reply-To: <1470757664-25161-2-git-send-email-pbonzini@redhat.com>

On Tue, 08/09 17:47, Paolo Bonzini wrote:
> Include Python and shell scripts, and make an exception for Perl
> scripts we imported from Linux or elsewhere.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  scripts/checkpatch.pl | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b7cb4ab..7ccf6a8 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1351,8 +1351,10 @@ sub process {
>  			WARN("adding a line without newline at end of file\n" . $herecurr);
>  		}
>  
> -# check we are in a valid source file C or perl if not then ignore this hunk
> -		next if ($realfile !~ /\.(h|c|cpp|pl)$/);
> +# check we are in a valid source file; if not then tabs are allowed.
> +# make an exception from some scripts imported from other projects.

s/from some/for some/ ?

> +		next if ($realfile !~ /\.(h|c|cpp|pl|py|sh)$/);
> +		next if ($realfile =~ /(checkpatch|get_maintainer|texi2pod)\.pl$/);
>  
>  # in QEMU, no tabs are allowed
>  		if ($rawline =~ /^\+.*\t/) {
> -- 
> 2.7.4
> 
> 
> 

  reply	other threads:[~2016-08-10  2:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-09 15:47 [Qemu-devel] [PATCH 0/3] checkpatch tweaks Paolo Bonzini
2016-08-09 15:47 ` [Qemu-devel] [PATCH 1/3] checkpatch: tweak the files in which TABs are checked Paolo Bonzini
2016-08-10  2:06   ` Fam Zheng [this message]
2016-08-10  6:46   ` Markus Armbruster
2016-08-10  7:32     ` Cornelia Huck
2016-08-09 15:47 ` [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors Paolo Bonzini
2016-08-10  6:53   ` Markus Armbruster
2016-08-10  7:08     ` Paolo Bonzini
2016-08-10  7:48       ` Markus Armbruster
2016-08-10  7:58         ` Paolo Bonzini
2016-08-10  7:48       ` Cornelia Huck
2016-08-10  7:46   ` Cornelia Huck
2016-08-10  7:58     ` Paolo Bonzini
2016-08-09 15:47 ` [Qemu-devel] [PATCH 3/3] checkpatch: default to success if only warnings Paolo Bonzini
2016-08-10  2:10 ` [Qemu-devel] [PATCH 0/3] checkpatch tweaks Fam Zheng
2016-08-10  7:15   ` Christian Borntraeger
2016-08-10  7:52 ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810020641.GF11351@al.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).