From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bXJZo-0003pS-Q3
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 22:49:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bXJZi-0004At-Vc
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 22:49:03 -0400
Date: Wed, 10 Aug 2016 10:41:55 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160810024155.GI11351@al.usersys.redhat.com>
References: <1470027888-24381-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1470027888-24381-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org

On Mon, 08/01 13:04, Fam Zheng wrote:
> Currently "make docker-test-mingw@fedora" has a warning like:
> 
>     /tmp/qemu-test/src/block/curl.c: In function 'curl_sock_cb':
>     /tmp/qemu-test/src/block/curl.c:172:6: warning: format '%d' expects
>     argument of type 'int', but argument 4 has type 'curl_socket_t {aka long
>     long unsigned int}'
>          DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
>           ^
>     cc1: all warnings being treated as errors
> 
> Cast to int to suppress it.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/curl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/curl.c b/block/curl.c
> index da9f5e8..426fb4d 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -169,7 +169,7 @@ static int curl_sock_cb(CURL *curl, curl_socket_t fd, int action,
>      state->sock_fd = fd;
>      s = state->s;
>  
> -    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
> +    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, (int)fd);
>      switch (action) {
>          case CURL_POLL_IN:
>              aio_set_fd_handler(s->aio_context, fd, false,
> -- 
> 2.7.4
> 
> 

Since this is blocking the mingw testing on patchew, I'm taking this in my
tree. Applied to my docker branch:

https://github.com/famz/qemu/tree/docker

Thanks,
Fam