From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXJxw-0005r9-C8 for qemu-devel@nongnu.org; Tue, 09 Aug 2016 23:14:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXJxv-0004FX-Ev for qemu-devel@nongnu.org; Tue, 09 Aug 2016 23:14:00 -0400 Date: Tue, 9 Aug 2016 23:13:52 -0400 From: Jeff Cody Message-ID: <20160810031352.GF5270@localhost.localdomain> References: <1470725407-5051-1-git-send-email-famz@redhat.com> <1470725407-5051-9-git-send-email-famz@redhat.com> <20160809214554.GB5270@localhost.localdomain> <20160810012856.GC11351@al.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160810012856.GC11351@al.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 8/9] vl: Switch qemu_uuid to QemuUUID List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, sw@weilnetz.de, mdroth@linux.vnet.ibm.com, armbru@redhat.com, pbonzini@redhat.com, mreitz@redhat.com, berrange@redhat.com On Wed, Aug 10, 2016 at 09:28:56AM +0800, Fam Zheng wrote: > On Tue, 08/09 17:45, Jeff Cody wrote: > > > diff --git a/util/uuid.c b/util/uuid.c > > > index 80c89f0..5d8bc88 100644 > > > --- a/util/uuid.c > > > +++ b/util/uuid.c > > > @@ -61,18 +61,19 @@ char *qemu_uuid_unparse_strdup(const QemuUUID *uuid) > > > uu[13], uu[14], uu[15]); > > > } > > > > > > -int qemu_uuid_parse(const char *str, uint8_t *uuid) > > > +int qemu_uuid_parse(QemuUUID *uuid, const char *str) > > > > Wait, what's going on here? Why switch the argument order away from the > > libuuid order? > > I don't see a strong reason to strictly follow libuuid, and thought it would be > more nature to put the output first, but since it's a surprise to you, I can > change it back. > I just wasn't sure if it was intentional (since it wasn't in the commit message, and it was a difference from v2). If you feel strongly about changing the order, I can be OK with it too :)