From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXLNY-0001yV-N3 for qemu-devel@nongnu.org; Wed, 10 Aug 2016 00:44:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXLNU-0006VD-GT for qemu-devel@nongnu.org; Wed, 10 Aug 2016 00:44:31 -0400 Date: Wed, 10 Aug 2016 13:14:47 +1000 From: David Gibson Message-ID: <20160810031447.GI9057@voom.fritz.box> References: <1470762001-414-1-git-send-email-thuth@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9iyR+p8Z2cn535Lj" Content-Disposition: inline In-Reply-To: <1470762001-414-1-git-send-email-thuth@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/5] spapr: Fix regression in CPU alias handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org, abologna@redhat.com, bharata@linux.vnet.ibm.com, clg@kaod.org --9iyR+p8Z2cn535Lj Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 09, 2016 at 06:59:56PM +0200, Thomas Huth wrote: > There is a regression with the "-cpu" parameter which has been > introduced by the spapr CPU hotplug code: We used to allow to specify > a "CPU family" name with the "-cpu" parameter when running on KVM so > that the user does not need to know the gory details of the exact > CPU version of the host CPU. For example, it was possible to > use "-cpu POWER8" on a POWER8E host CPU. This behavior does not > work anymore with the new hot-pluggable spapr-cpu-core types. > Since libvirt already heavily depends on the old behavior, this > is quite a severe regression in the QEMU parameter interface, thus > I think these patches should still go into 2.7 if possible, to avoid > that we break the "upper layers" with the final 2.7 release. >=20 > This patch series fixes the regression (and two more minor bugs) > by registering a family type for the spapr-cpu-core type, too > (see the last patch). However, since that name clashes with the > alias types that have been defined in spapr_cpu_core.c, we first > have to introduce there a better way to handle CPU aliases (see > the first two patches). > The third patch fixes a small memory leak along the way, and > the fourth patch makes sure that we do not mess up the generic > CPU family type registration anymore (which was another regression > introduced with the spapr CPU hotplug code). >=20 > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=3D1363812 Applied to ppc-for-2.7, thanks. >=20 > v2: > - Add the "remove extra type variable" patch from C=E9dric Le Goater. > - Remove the "Do not leak the memory of the type string" patch > since it got obsoleted by C=E9dric's patch >=20 > C=E9dric Le Goater (1): > spapr: remove extra type variable >=20 > Thomas Huth (4): > ppc: Introduce a function to look up CPU alias strings > hw/ppc/spapr: Look up CPU alias names instead of hard-coding the > aliases > ppc/kvm: Do not mess up the generic CPU family registration > ppc/kvm: Register also a generic spapr CPU core family type >=20 > hw/ppc/spapr.c | 15 ++++++--------- > hw/ppc/spapr_cpu_core.c | 38 +++++++++++++++++++++----------------- > target-ppc/cpu.h | 1 + > target-ppc/kvm.c | 19 +++++++++++-------- > target-ppc/translate_init.c | 13 +++++++++++++ > 5 files changed, 52 insertions(+), 34 deletions(-) >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --9iyR+p8Z2cn535Lj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXqpwnAAoJEGw4ysog2bOS4ccQAMQyuLHeoKqRF40rHnSoZzrw /03nTmObHNqVq9hXLhW3/SiTg+ZSqivJy1JTUPUNgqL5Zcd/g82+P7RyD/sh+Pdy ySj3LUlchoLy3qQ2hIonRISzo2Fx9mzAhnxr4lnM8cm/5DJAJ55d2ZrA2zexvywo iGwE11NylQWdIJStlrLa8YiuODRSZkEUaEU2Gb3+FVkuq4dR3nZnJog/BeyzcelX BkTvnvnBfBVAp7EsH0aogMHHmMSUhOQAFDw7UEQrB/vUKsIZpELI/02NvMVSWqf+ hdMvORQpx2iKqk+2HHmO57PtiIERd6jABXygOsC1jVAiX5XGD+SkNcj2ux+7DsdW X+vYhU8Q/ieAn6TpGdcBSnNvcHXhAyAGg02FCPCFQygEnrJ3r90SGTasdIDKKNaV 8+YiBWVtBJhOOvfdRRseehfQ2bJ+xo6ly9p3KJ9Fo2DJ5Xat0Q2hwM68wIoD+bBn Olvkr7INvYx1TnNPJv0xNly8Y1eM1/DIW3lnro38gyxvD4LcbLyA5Ga0gGGzMRNW kyGO/Rl3q5sMdTiAHGOEYCOBECBVu9z761c/+yFzFlumdlovPCJGchmFqAiKgUO4 sF7XRE+N+jyxiEGP+uVakbjdkPxcs3nihY8bUz1u4jXO7Cewl3MnwxzSCjqNNQdJ xuNB3DnIhnpA21xIjpYJ =5edu -----END PGP SIGNATURE----- --9iyR+p8Z2cn535Lj--