Re: [Qemu-devel] [PATCH v2 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1945 bytes --]

On Sun, Aug 07, 2016 at 07:01:01PM -0700, Ashish Mittal wrote:
> This patch adds support for a new block device type called "vxhs".
> Source code for the library that this code loads can be downloaded from:
> https://github.com/MittalAshish/libqnio.git
> 
> Version 2 patch submission fixes the following issues:
> (1) Removed code to dlopen library. We now check if libqnio is installed during
>     configure, and directly link with it.
> (2) Changed file headers to mention GPLv2-or-later license.
> (3) Removed unnecessary type casts and inlines.
> (4) Removed custom tokenize function and modified code to use g_strsplit.
> (5) Replaced malloc/free with g_new/g_free and removed code that checks for
>     memory allocation failure conditions.
> (6) Removed some block ops implementations that were place-holders only.
> (7) Removed all custom debug messages. Added new messages in block/trace-events
> (8) Other miscellaneous corrections.
> 
> TODO: QAPI changes and (fixes to) review comments from Stefan.
> Signed-off-by: Ashish Mittal <ashish.mittal@veritas.com>
> ---
>  block/Makefile.objs |    2 +
>  block/trace-events  |   40 ++
>  block/vxhs.c        | 1199 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  block/vxhs.h        |  294 +++++++++++++
>  configure           |   50 +++
>  5 files changed, 1585 insertions(+)
>  create mode 100644 block/vxhs.c
>  create mode 100644 block/vxhs.h

I'll review v3 with the issues I raised addressed.

Please put the patch changelog below the '---' line.  This way the
changelog is not included in the git history when the patch is merged.
The changelog is only useful while the patch is being discussed on the
mailing list but shouldn't be included in the git-log(1) output.
Typically it looks like this:

---
v2:
 * Removed code to dlopen library. We now check if libqnio is installed
   during configure, and directly link with it.
 ...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]