From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXgTk-0008IY-II for qemu-devel@nongnu.org; Wed, 10 Aug 2016 23:16:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXgTh-0002Xw-8v for qemu-devel@nongnu.org; Wed, 10 Aug 2016 23:16:20 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:14221 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXgTh-0002Xq-2X for qemu-devel@nongnu.org; Wed, 10 Aug 2016 23:16:17 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u7B39b7E134137 for ; Wed, 10 Aug 2016 23:16:16 -0400 Received: from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146]) by mx0b-001b2d01.pphosted.com with ESMTP id 24qm9vj21a-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 10 Aug 2016 23:16:16 -0400 Received: from localhost by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 11 Aug 2016 13:16:13 +1000 Date: Thu, 11 Aug 2016 08:46:06 +0530 From: Bharata B Rao Reply-To: bharata@linux.vnet.ibm.com References: <1470856081-28168-1-git-send-email-clg@kaod.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1470856081-28168-1-git-send-email-clg@kaod.org> Message-Id: <20160811031606.GB4514@in.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for 2.7] ppc: parse cpu features once List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: qemu-ppc@nongnu.org, David Gibson , qemu-devel@nongnu.org, Eduardo Habkost , Greg Kurz On Wed, Aug 10, 2016 at 09:08:01PM +0200, C=E9dric Le Goater wrote: > From: Greg Kurz >=20 > Considering that features are converted to global properties and > global properties are automatically applied to every new instance > of created CPU (at object_new() time), there is no point in > parsing cpu_model string every time a CPU created. So move > parsing outside CPU creation loop and do it only once. >=20 > Parsing also should be done before any CPU is created so that > features would affect the first CPU a well. >=20 > This patch does that for all PowerPC machine types. >=20 > It is based on previous work from Bharata: >=20 > https://lists.nongnu.org/archive/html/qemu-devel/2016-06/msg07564.html >=20 > Signed-off-by: Greg Kurz > [clg: only kept the fix for the spapr platform. support for other > platform will be added in 2.8 ] > Signed-off-by: C=E9dric Le Goater Tested-by: Bharata B Rao