qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Emilio G. Cota" <cota@braap.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"Brent W. Baccala" <cosine@freesoft.org>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] correctly handle resize of empty hash tree
Date: Thu, 11 Aug 2016 05:41:22 -0400	[thread overview]
Message-ID: <20160811094122.GA9194@flamenco> (raw)
In-Reply-To: <20160811104502.7aa4fe9e@nial.brq.redhat.com>

On Thu, Aug 11, 2016 at 10:45:02 +0200, Igor Mammedov wrote:
> On Wed, 10 Aug 2016 17:19:48 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> > The patch makes sense, but I think we don't need to call qht_reset_size
> > at all.
> > 
> > tb_flush should not do anything if using KVM. There are several ways to
> > do this:
> > 
> > - put the tb_flush call under "if (tcg_enabled())"
> > 
> > - add an "if (!tcg_enabled()) return;" in tb_flush

I like this option the most.

My patch to fix this issue was written thinking that tb_flush was
strangely needed for gdb to work under KVM. If that's not the
case, then let's go for the real fix [above].

Thanks,

		E.

  reply	other threads:[~2016-08-11  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10  1:05 [Qemu-devel] [PATCH] correctly handle resize of empty hash tree Brent W. Baccala
2016-08-10 15:11 ` Igor Mammedov
2016-08-10 15:19 ` Paolo Bonzini
2016-08-11  8:45   ` Igor Mammedov
2016-08-11  9:41     ` Emilio G. Cota [this message]
2016-08-25 17:54       ` Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160811094122.GA9194@flamenco \
    --to=cota@braap.org \
    --cc=cosine@freesoft.org \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).