From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56976)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1bXmUe-0000IP-95
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 05:41:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1bXmUZ-0004E1-AO
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 05:41:40 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45793)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cota@braap.org>) id 1bXmUW-0004AC-SN
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 05:41:35 -0400
Date: Thu, 11 Aug 2016 05:41:22 -0400
From: "Emilio G. Cota" <cota@braap.org>
Message-ID: <20160811094122.GA9194@flamenco>
References: <CADyN2VyWDKGgg-VQFtDnVLP2Bu1e=DoOQhNYiR1yEoDrS4mwgw@mail.gmail.com>
	<9b548360-dbce-8fb3-c21a-e491eeff713d@redhat.com>
	<20160811104502.7aa4fe9e@nial.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160811104502.7aa4fe9e@nial.brq.redhat.com>
Subject: Re: [Qemu-devel] [PATCH] correctly handle resize of empty hash tree
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "Brent W. Baccala" <cosine@freesoft.org>, qemu-devel@nongnu.org

On Thu, Aug 11, 2016 at 10:45:02 +0200, Igor Mammedov wrote:
> On Wed, 10 Aug 2016 17:19:48 +0200
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> > The patch makes sense, but I think we don't need to call qht_reset_size
> > at all.
> > 
> > tb_flush should not do anything if using KVM. There are several ways to
> > do this:
> > 
> > - put the tb_flush call under "if (tcg_enabled())"
> > 
> > - add an "if (!tcg_enabled()) return;" in tb_flush

I like this option the most.

My patch to fix this issue was written thinking that tb_flush was
strangely needed for gdb to work under KVM. If that's not the
case, then let's go for the real fix [above].

Thanks,

		E.