From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXstB-0003RK-FG for qemu-devel@nongnu.org; Thu, 11 Aug 2016 12:31:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXst6-0006Mp-RT for qemu-devel@nongnu.org; Thu, 11 Aug 2016 12:31:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXst6-0006Mj-J4 for qemu-devel@nongnu.org; Thu, 11 Aug 2016 12:31:20 -0400 Date: Thu, 11 Aug 2016 17:31:16 +0100 From: "Daniel P. Berrange" Message-ID: <20160811163116.GK27458@redhat.com> Reply-To: "Daniel P. Berrange" References: <147093187892.24979.13675730389787023008.stgit@fimbulvetr.bsc.es> <147093188968.24979.8739712285459220697.stgit@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <147093188968.24979.8739712285459220697.stgit@fimbulvetr.bsc.es> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/2] trace: Avoid implicit bool->integer conversions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?B?TGx1w61z?= Vilanova Cc: qemu-devel@nongnu.org, Paolo Bonzini , Stefan Hajnoczi On Thu, Aug 11, 2016 at 06:11:29PM +0200, Llu=C3=ADs Vilanova wrote: > An explicit if/else is clearer than arithmetic assuming #true is 1, > while the compiler should be able to generate just as optimal code. >=20 > Signed-off-by: Llu=C3=ADs Vilanova > --- > stubs/trace-control.c | 9 +++++++-- > trace/control-target.c | 18 ++++++++++++++---- > 2 files changed, 21 insertions(+), 6 deletions(-) >=20 > diff --git a/stubs/trace-control.c b/stubs/trace-control.c > index 3740c38..099c2b5 100644 > --- a/stubs/trace-control.c > +++ b/stubs/trace-control.c > @@ -21,8 +21,13 @@ void trace_event_set_state_dynamic(TraceEvent *ev, b= ool state) > TraceEventID id; > assert(trace_event_get_state_static(ev)); > id =3D trace_event_get_id(ev); > - trace_events_enabled_count +=3D state - trace_events_dstate[id]; > - trace_events_dstate[id] =3D state; > + if (state) { > + trace_events_enabled_count++; > + trace_events_dstate[id] =3D 1; > + } else { > + trace_events_enabled_count--; SHouldn't this be trace_events_enabled_count -=3D trace_events_dstate[id]= ; as it is possible to call this method for a trace event that is a per-vcp= u event > + trace_events_dstate[id] =3D 0; > + } > } > =20 > void trace_event_set_vcpu_state_dynamic(CPUState *vcpu, > diff --git a/trace/control-target.c b/trace/control-target.c > index 4ee3733..4e2e727 100644 > --- a/trace/control-target.c > +++ b/trace/control-target.c > @@ -18,8 +18,13 @@ void trace_event_set_state_dynamic_init(TraceEvent *= ev, bool state) > TraceEventID id =3D trace_event_get_id(ev); > assert(trace_event_get_state_static(ev)); > /* Ignore "vcpu" property, since no vCPUs have been created yet */ > - trace_events_enabled_count +=3D state - trace_events_dstate[id]; > - trace_events_dstate[id] =3D state; > + if (state) { > + trace_events_enabled_count++; > + trace_events_dstate[id] =3D 1; > + } else { > + trace_events_enabled_count--; > + trace_events_dstate[id] =3D 0; > + } > } > =20 > void trace_event_set_state_dynamic(TraceEvent *ev, bool state) > @@ -32,8 +37,13 @@ void trace_event_set_state_dynamic(TraceEvent *ev, b= ool state) > } > } else { > TraceEventID id =3D trace_event_get_id(ev); > - trace_events_enabled_count +=3D state - trace_events_dstate[id= ]; > - trace_events_dstate[id] =3D state; > + if (state) { > + trace_events_enabled_count++; > + trace_events_dstate[id] =3D 1; > + } else { > + trace_events_enabled_count--; > + trace_events_dstate[id] =3D 0; > + } > } > } > =20 >=20 Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|