From: Fam Zheng <famz@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org,
sw@weilnetz.de, jcody@redhat.com, mdroth@linux.vnet.ibm.com,
armbru@redhat.com, pbonzini@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 1/9] util: Add UUID API
Date: Fri, 12 Aug 2016 10:01:26 +0800 [thread overview]
Message-ID: <20160812020126.GC2759@al.usersys.redhat.com> (raw)
In-Reply-To: <2c193764-6c6a-25fe-f59d-9a5fd9fa838d@twiddle.net>
On Thu, 08/11 23:21, Richard Henderson wrote:
> On 08/11/2016 05:50 AM, Fam Zheng wrote:
> >+void qemu_uuid_bswap(QemuUUID *uuid)
> >+{
> >+ bswap32s((uint32_t *)&uuid->data[0]);
> >+ bswap16s((uint16_t *)&uuid->data[4]);
> >+ bswap16s((uint16_t *)&uuid->data[6]);
> >+}
>
> You have alignment problems here too. Perhaps you really did want
> to add uint32_t (and uint16_t?) as union members to QemuUUID.
But that may not be enough for embedded QemuUUID in a packed structure, such as
in block/vdi.c. So I'll also add an assertion here.
Fam
next prev parent reply other threads:[~2016-08-12 2:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 4:50 [Qemu-devel] [PATCH v4 0/9] UUID clean ups for 2.8 Fam Zheng
2016-08-11 4:50 ` [Qemu-devel] [PATCH v4 1/9] util: Add UUID API Fam Zheng
2016-08-11 22:21 ` Richard Henderson
2016-08-12 2:01 ` Fam Zheng [this message]
2016-08-12 6:19 ` Richard Henderson
2016-08-11 4:50 ` [Qemu-devel] [PATCH v4 2/9] vhdx: Use QEMU " Fam Zheng
2016-08-11 4:50 ` [Qemu-devel] [PATCH v4 3/9] vdi: " Fam Zheng
2016-08-11 4:50 ` [Qemu-devel] [PATCH v4 4/9] vpc: " Fam Zheng
2016-08-11 4:50 ` [Qemu-devel] [PATCH v4 5/9] crypto: Switch to " Fam Zheng
2016-08-11 4:50 ` [Qemu-devel] [PATCH v4 6/9] tests: No longer dependent on CONFIG_UUID Fam Zheng
2016-08-11 4:50 ` [Qemu-devel] [PATCH v4 7/9] configure: Remove detection code for UUID Fam Zheng
2016-08-11 4:50 ` [Qemu-devel] [PATCH v4 8/9] vl: Switch qemu_uuid to QemuUUID Fam Zheng
2016-08-11 4:50 ` [Qemu-devel] [PATCH v4 9/9] tests: Add uuid tests Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812020126.GC2759@al.usersys.redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).