From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bYDtm-0001H2-Fn for qemu-devel@nongnu.org; Fri, 12 Aug 2016 10:57:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bYDtk-0007qp-Jj for qemu-devel@nongnu.org; Fri, 12 Aug 2016 10:57:25 -0400 Date: Fri, 12 Aug 2016 11:01:12 +0200 From: Kevin Wolf Message-ID: <20160812090112.GA5339@noname.redhat.com> References: <1470827847-15983-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470827847-15983-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] test-coroutine: Fix coroutine pool corruption List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Am 10.08.2016 um 13:17 hat Kevin Wolf geschrieben: > The test case overwrites the Coroutine object with 0xff as a way to > assert that the coroutine isn't used any more. However, this means that > the coroutine pool now contains a corrupted object and later test cases > may get this corrupted object and crash. > > This patch saves the real content of the object and restores it after > completing the test. The only use of the coroutine pool between those > two points is the deletion of co2. As this only means an insertion at > the head of an SLIST (release_pool or alloc_pool), it doesn't access the > invalid list pointers that co1 has during this period. > > Signed-off-by: Kevin Wolf Applied to block-next. Kevin