From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, pbonzini@redhat.com,
qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] coroutine: Assertions and debugging aids
Date: Fri, 12 Aug 2016 10:55:26 +0100 [thread overview]
Message-ID: <20160812095526.GE10583@stefanha-x1.localdomain> (raw)
In-Reply-To: <1470932542-12311-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 839 bytes --]
On Thu, Aug 11, 2016 at 06:22:20PM +0200, Kevin Wolf wrote:
> A while ago we were debugging a hang where coroutines were waiting for a mutex
> to be unlocked, but we couldn't find out who held the lock. This series adds
> some information to Coroutine and CoMutex that both allows to add a few
> assertions to check locking behaviour and can be used to find the culprit when
> analysing a core dump.
>
> Kevin Wolf (2):
> coroutine: Let CoMutex remember who holds it
> coroutine: Assert that no locks are held on termination
>
> include/qemu/coroutine.h | 1 +
> include/qemu/coroutine_int.h | 1 +
> util/qemu-coroutine-lock.c | 14 ++++++++++++++
> util/qemu-coroutine.c | 1 +
> 4 files changed, 17 insertions(+)
>
> --
> 1.8.3.1
>
>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-12 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 16:22 [Qemu-devel] [PATCH 0/2] coroutine: Assertions and debugging aids Kevin Wolf
2016-08-11 16:22 ` [Qemu-devel] [PATCH 1/2] coroutine: Let CoMutex remember who holds it Kevin Wolf
2016-08-11 16:22 ` [Qemu-devel] [PATCH 2/2] coroutine: Assert that no locks are held on termination Kevin Wolf
2016-08-11 16:35 ` [Qemu-devel] [PATCH 0/2] coroutine: Assertions and debugging aids Paolo Bonzini
2016-08-12 9:55 ` Stefan Hajnoczi [this message]
2016-08-15 12:18 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812095526.GE10583@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).