Re: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1471149312-28148-1-git-send-email-ashish.mittal@veritas.com
Subject: [Qemu-devel] [PATCH v3 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1471149312-28148-1-git-send-email-ashish.mittal@veritas.com -> patchew/1471149312-28148-1-git-send-email-ashish.mittal@veritas.com
Switched to a new branch 'test'
7b11227 block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

=== OUTPUT BEGIN ===
Checking PATCH 1/1: block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support...
WARNING: line over 80 characters
#305: FILE: block/vxhs.c:212:
+            trace_vxhs_iio_callback_fail(reason, acb, acb->segments, acb->size, error);

WARNING: line over 80 characters
#341: FILE: block/vxhs.c:248:
+        trace_vxhs_iio_callback_ready(((BDRVVXHSState *)ctx)->vdisk_guid, error);

ERROR: spaces required around that '+' (ctx:VxV)
#608: FILE: block/vxhs.c:515:
+            trace_vxhs_parse_json_hostinfo(i+1, vxhsconf->host, vxhsconf->port);
                                             ^

ERROR: spaces required around that '==' (ctx:VxV)
#669: FILE: block/vxhs.c:576:
+        if (i==0 && (strstr(uri->path, "vxhs") == NULL)) {
              ^

ERROR: spaces required around that '+' (ctx:VxV)
#670: FILE: block/vxhs.c:577:
+            conf->vdisk_id = g_new0(char, strlen(uri->path)+3);
                                                            ^

ERROR: spaces required around that '+' (ctx:VxV)
#675: FILE: block/vxhs.c:582:
+        trace_vxhs_parse_uri_hostinfo(i+1, vxhsconf->host, vxhsconf->port);
                                        ^

ERROR: suspect code indent for conditional statements (4, 4)
#1265: FILE: block/vxhs.c:1172:
+    if (res != 0) {
+    trace_vxhs_switch_storage_agent_failed(

ERROR: g_free(NULL) is safe this check is probably not required
#1379: FILE: block/vxhs.c:1286:
+    if (of_vsa_addr) {
+        g_free(of_vsa_addr);

ERROR: g_free(NULL) is safe this check is probably not required
#1382: FILE: block/vxhs.c:1289:
+    if (file_name) {
+        g_free(file_name);

total: 7 errors, 2 warnings, 1902 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org