From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZIRJ-0000Oi-3e for qemu-devel@nongnu.org; Mon, 15 Aug 2016 10:00:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZIRH-00046K-8u for qemu-devel@nongnu.org; Mon, 15 Aug 2016 10:00:28 -0400 Date: Mon, 15 Aug 2016 16:00:18 +0200 From: Kevin Wolf Message-ID: <20160815140018.GG6024@noname.str.redhat.com> References: <20160815132927.2502-1-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160815132927.2502-1-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.7? v3 0/5] block: Use QemuOpts for runtime options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Paolo Bonzini , Jeff Cody , "Richard W . M . Jones" Am 15.08.2016 um 15:29 hat Max Reitz geschrieben: > The SSH and NBD block drivers currently directly extract their runtime > options from the options QDict they receive. This is bad practice and > can lead to segmentation faults (which, however, will always be a NULL > pointer dereference, so it should not be exploitable beyond a DoS). > > This series fixes that by using QemuOpts instead (like all the other > block drivers do). > > With this series applied, there are only two instances of "qdict_get" > left in block/, both of which appear to be safe. Thanks, applied. Kevin