Re: [Qemu-devel] [PATCH v10 00/11] Provide a QOM-based authorization API

[no-reply@patchew.org]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1471270945-19975-1-git-send-email-berrange@redhat.com
Subject: [Qemu-devel] [PATCH v10 00/11] Provide a QOM-based authorization API
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1471270945-19975-1-git-send-email-berrange@redhat.com -> patchew/1471270945-19975-1-git-send-email-berrange@redhat.com
Switched to a new branch 'test'
2b42606 qmp: add support for mixed typed input visitor
03ccf4a util: add QAuthZPAM object type for authorizing using PAM
681b2e7 acl: delete existing ACL implementation
3c99fc6 util: add QAuthZSimple object type for a simple access control list
5517080 util: add QAuthZ object as an authorization base class
0393e1c qom: support arbitrary non-scalar properties with -object
f63ef93 qapi: add a QmpInputVisitor that does string conversion
650ee1f qapi: rename QmpOutputVisitor to QObjectOutputVisitor
2a1a17d qapi: rename QmpInputVisitor to QObjectInputVisitor
d0ded29 option: make parse_option_bool/number non-static
3aebeb5 qdict: implement a qdict_crumple method for un-flattening a dict

=== OUTPUT BEGIN ===
Checking PATCH 1/11: qdict: implement a qdict_crumple method for un-flattening a dict...
Checking PATCH 2/11: option: make parse_option_bool/number non-static...
Checking PATCH 3/11: qapi: rename QmpInputVisitor to QObjectInputVisitor...
ERROR: open brace '{' following struct go on the same line
#572: FILE: qapi/qobject-input-visitor.c:27:
+typedef struct StackObject
+{

ERROR: open brace '{' following struct go on the same line
#583: FILE: qapi/qobject-input-visitor.c:38:
+struct QObjectInputVisitor
+{

WARNING: line over 80 characters
#2480: FILE: tests/test-qobject-input-strict.c:94:
+    v = validate_test_init(data, "{ 'integer': -42, 'boolean': true, 'string': 'foo' }");

ERROR: line over 90 characters
#2508: FILE: tests/test-qobject-input-strict.c:122:
+    v = validate_test_init(data, "[ { 'string': 'string0', 'integer': 42 }, { 'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44 } ]");

ERROR: line over 90 characters
#2561: FILE: tests/test-qobject-input-strict.c:175:
+    v = validate_test_init(data, "{ 'integer': -42, 'boolean': true, 'string': 'foo', 'extra': 42 }");

ERROR: line over 90 characters
#2575: FILE: tests/test-qobject-input-strict.c:189:
+    v = validate_test_init(data, "{ 'string0': 'string0', 'dict1': { 'string1': 'string1', 'dict2': { 'userdef1': { 'integer': 42, 'string': 'string', 'extra': [42, 23, {'foo':'bar'}] }, 'string2': 'string2'}}}");

ERROR: line over 90 characters
#2589: FILE: tests/test-qobject-input-strict.c:203:
+    v = validate_test_init(data, "[ { 'string': 'string0', 'integer': 42 }, { 'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44, 'extra': 'ggg' } ]");

WARNING: line over 80 characters
#2618: FILE: tests/test-qobject-input-strict.c:232:
+    v = validate_test_init(data, "{ 'string': 'c', 'integer': 41, 'boolean': true }");

ERROR: line over 90 characters
#2633: FILE: tests/test-qobject-input-strict.c:247:
+    v = validate_test_init(data, "{ 'integer': 42, 'string': 'c', 'string1': 'd', 'string2': 'e' }");

ERROR: line over 90 characters
#2677: FILE: tests/test-qobject-input-strict.c:291:
+                               void (*test_func)(TestInputVisitorData *data, const void *user_data))

ERROR: line over 90 characters
#2900: FILE: tests/test-qobject-input-visitor.c:173:
+    v = visitor_input_test_init(data, "{ 'integer': -42, 'boolean': true, 'string': 'foo' }");

ERROR: line over 90 characters
#2941: FILE: tests/test-qobject-input-visitor.c:214:
+    v = visitor_input_test_init(data, "[ { 'string': 'string0', 'integer': 42 }, { 'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44 } ]");

ERROR: line over 90 characters
#2981: FILE: tests/test-qobject-input-visitor.c:254:
+    v = visitor_input_test_init(data, "{ 'integer': -42, 'boolean': true, 'string': 'foo' }");

ERROR: line over 90 characters
#3478: FILE: tests/test-qobject-input-visitor.c:751:
+                                   void (*test_func)(TestInputVisitorData *data, const void *user_data))

total: 12 errors, 2 warnings, 1864 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/11: qapi: rename QmpOutputVisitor to QObjectOutputVisitor...
ERROR: line over 90 characters
#2555: FILE: tests/test-qobject-output-visitor.c:792:
+                                    void (*test_func)(TestOutputVisitorData *data, const void *user_data))

total: 1 errors, 0 warnings, 1384 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/11: qapi: add a QmpInputVisitor that does string conversion...
WARNING: line over 80 characters
#448: FILE: tests/test-qobject-input-visitor.c:420:
+    v = visitor_input_test_init_full(data, false, false, "{ 'a': null, 'b': '' }");

total: 0 errors, 1 warnings, 423 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/11: qom: support arbitrary non-scalar properties with -object...
Checking PATCH 7/11: util: add QAuthZ object as an authorization base class...
Checking PATCH 8/11: util: add QAuthZSimple object type for a simple access control list...
Checking PATCH 9/11: acl: delete existing ACL implementation...
Checking PATCH 10/11: util: add QAuthZPAM object type for authorizing using PAM...
Checking PATCH 11/11: qmp: add support for mixed typed input visitor...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org