From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZWFX-00071a-9j for qemu-devel@nongnu.org; Tue, 16 Aug 2016 00:45:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZWFV-0005ZD-5B for qemu-devel@nongnu.org; Tue, 16 Aug 2016 00:45:15 -0400 Date: Tue, 16 Aug 2016 14:21:35 +1000 From: David Gibson Message-ID: <20160816042135.GG14530@voom.fritz.box> References: <1470901008-3284-1-git-send-email-raji@linux.vnet.ibm.com> <1470901008-3284-3-git-send-email-raji@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0qt3EE9wi45a2ZFX" Content-Disposition: inline In-Reply-To: <1470901008-3284-3-git-send-email-raji@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 2/5] target-ppc: add vector extract instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rajalakshmi Srinivasaraghavan Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, benh@kernel.crashing.org --0qt3EE9wi45a2ZFX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 11, 2016 at 01:06:45PM +0530, Rajalakshmi Srinivasaraghavan wro= te: > The following vector extract instructions are added from ISA 3.0. >=20 > vextractub - Vector Extract Unsigned Byte > vextractuh - Vector Extract Unsigned Halfword > vextractuw - Vector Extract Unsigned Word > vextractd - Vector Extract Unsigned Doubleword >=20 > Signed-off-by: Rajalakshmi Srinivasaraghavan > --- > target-ppc/helper.h | 4 ++++ > target-ppc/int_helper.c | 26 ++++++++++++++++++++++++++ > target-ppc/translate/vmx-impl.c | 10 ++++++++++ > target-ppc/translate/vmx-ops.c | 10 +++++++--- > 4 files changed, 47 insertions(+), 3 deletions(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 0923779..59e7b88 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -250,6 +250,10 @@ DEF_HELPER_2(vspltisw, void, avr, i32) > DEF_HELPER_3(vspltb, void, avr, avr, i32) > DEF_HELPER_3(vsplth, void, avr, avr, i32) > DEF_HELPER_3(vspltw, void, avr, avr, i32) > +DEF_HELPER_3(vextractub, void, avr, avr, i32) > +DEF_HELPER_3(vextractuh, void, avr, avr, i32) > +DEF_HELPER_3(vextractuw, void, avr, avr, i32) > +DEF_HELPER_3(vextractd, void, avr, avr, i32) > DEF_HELPER_3(vinsertb, void, avr, avr, i32) > DEF_HELPER_3(vinserth, void, avr, avr, i32) > DEF_HELPER_3(vinsertw, void, avr, avr, i32) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 3f8e439..a917bd5 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -1819,6 +1819,32 @@ VINSERT(h, u16, 3) > VINSERT(w, u32, 1) > VINSERT(d, u64, 0) > #undef VINSERT > +#if defined(HOST_WORDS_BIGENDIAN) > +#define VEXTRACT(suffix, element, index) = \ > + void helper_vextract##suffix(ppc_avr_t *r, ppc_avr_t *b, uint32_t sp= lat) \ splat is not a good parameter name here, since the element is being extracted, rather than splatted. > + { = \ > + uint32_t s =3D sizeof(r->element[0]) * index; = \ > + ppc_avr_t result =3D { .u64 =3D { 0, 0 } }; = \ > + memcpy(&result.element[index], &b->u8[splat], = \ > + sizeof(result.element[0])); = \ > + *r =3D result; = \ > + } > +#else > +#define VEXTRACT(suffix, element, index) = \ > + void helper_vextract##suffix(ppc_avr_t *r, ppc_avr_t *b, uint32_t sp= lat) \ > + { = \ > + ppc_avr_t result =3D { .u64 =3D { 0, 0 } }; = \ > + uint32_t s =3D (16 - splat) - sizeof(r->element[0]); = \ > + uint32_t d =3D (ARRAY_SIZE(r->element) - index) - 1; > \ Same comments on the index value as for vinsert*. > + memcpy(&result.element[d], &b->u8[s], sizeof(result.element[0]))= ; \ > + *r =3D result; = \ > + } > +#endif > +VEXTRACT(ub, u8, 7) > +VEXTRACT(uh, u16, 3) > +VEXTRACT(uw, u32, 1) > +VEXTRACT(d, u64, 0) > +#undef VEXTRACT > =20 > #define VSPLTI(suffix, element, splat_type) \ > void helper_vspltis##suffix(ppc_avr_t *r, uint32_t splat) \ > diff --git a/target-ppc/translate/vmx-impl.c b/target-ppc/translate/vmx-i= mpl.c > index f6a97ac..766a645 100644 > --- a/target-ppc/translate/vmx-impl.c > +++ b/target-ppc/translate/vmx-impl.c > @@ -648,6 +648,10 @@ static void glue(gen_, name)(DisasContext *ctx) = \ > GEN_VXFORM_UIMM(vspltb, 6, 8); > GEN_VXFORM_UIMM(vsplth, 6, 9); > GEN_VXFORM_UIMM(vspltw, 6, 10); > +GEN_VXFORM_UIMM_SPLAT(vextractub, 6, 8, 15); > +GEN_VXFORM_UIMM_SPLAT(vextractuh, 6, 9, 14); > +GEN_VXFORM_UIMM_SPLAT(vextractuw, 6, 10, 12); > +GEN_VXFORM_UIMM_SPLAT(vextractd, 6, 11, 8); > GEN_VXFORM_UIMM_SPLAT(vinsertb, 6, 12, 15); > GEN_VXFORM_UIMM_SPLAT(vinserth, 6, 13, 14); > GEN_VXFORM_UIMM_SPLAT(vinsertw, 6, 14, 12); > @@ -656,6 +660,12 @@ GEN_VXFORM_UIMM_ENV(vcfux, 5, 12); > GEN_VXFORM_UIMM_ENV(vcfsx, 5, 13); > GEN_VXFORM_UIMM_ENV(vctuxs, 5, 14); > GEN_VXFORM_UIMM_ENV(vctsxs, 5, 15); > +GEN_VXFORM_DUAL(vspltb, PPC_NONE, PPC2_ALTIVEC_207, > + vextractub, PPC_NONE, PPC2_ISA300); > +GEN_VXFORM_DUAL(vsplth, PPC_NONE, PPC2_ALTIVEC_207, > + vextractuh, PPC_NONE, PPC2_ISA300); > +GEN_VXFORM_DUAL(vspltw, PPC_NONE, PPC2_ALTIVEC_207, > + vextractuw, PPC_NONE, PPC2_ISA300); > GEN_VXFORM_DUAL(vspltisb, PPC_NONE, PPC2_ALTIVEC_207, > vinsertb, PPC_NONE, PPC2_ISA300); > GEN_VXFORM_DUAL(vspltish, PPC_NONE, PPC2_ALTIVEC_207, > diff --git a/target-ppc/translate/vmx-ops.c b/target-ppc/translate/vmx-op= s.c > index ca69e56..aafe70b 100644 > --- a/target-ppc/translate/vmx-ops.c > +++ b/target-ppc/translate/vmx-ops.c > @@ -197,6 +197,13 @@ GEN_VXRFORM_DUAL(vcmpbfp, vcmpgtsd, 3, 15, PPC_ALTIV= EC, PPC_NONE) > #define GEN_VXFORM_DUAL_INV(name0, name1, opc2, opc3, inval0, inval1, ty= pe) \ > GEN_OPCODE_DUAL(name0##_##name1, 0x04, opc2, opc3, inval0, inval1, type,= \ > PPC_NONE) > +GEN_VXFORM_DUAL_INV(vspltb, vextractub, 6, 8, 0x00000000, 0x100000, > + PPC2_ALTIVEC_207), > +GEN_VXFORM_DUAL_INV(vsplth, vextractuh, 6, 9, 0x00000000, 0x100000, > + PPC2_ALTIVEC_207), > +GEN_VXFORM_DUAL_INV(vspltw, vextractuw, 6, 10, 0x00000000, 0x100000, > + PPC2_ALTIVEC_207), > +GEN_VXFORM_300_EXT(vextractd, 6, 11, 0x100000), > GEN_VXFORM_DUAL_INV(vspltisb, vinsertb, 6, 12, 0x00000000, 0x100000, > PPC2_ALTIVEC_207), > GEN_VXFORM_DUAL_INV(vspltish, vinserth, 6, 13, 0x00000000, 0x100000, > @@ -226,9 +233,6 @@ GEN_VXFORM_NOA(vrfiz, 5, 9), > =20 > #define GEN_VXFORM_UIMM(name, opc2, opc3) \ > GEN_HANDLER(name, 0x04, opc2, opc3, 0x00000000, PPC_ALTIVEC) > -GEN_VXFORM_UIMM(vspltb, 6, 8), > -GEN_VXFORM_UIMM(vsplth, 6, 9), > -GEN_VXFORM_UIMM(vspltw, 6, 10), > GEN_VXFORM_UIMM(vcfux, 5, 12), > GEN_VXFORM_UIMM(vcfsx, 5, 13), > GEN_VXFORM_UIMM(vctuxs, 5, 14), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --0qt3EE9wi45a2ZFX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXspTPAAoJEGw4ysog2bOSk+kP/iTxvxeL2/9HBHrGWIt3EHq+ x1FJba3OxNS8pkHWjwyDNN0H0/9Mz8fMwGW1QRq0OxSRmToe8JXYlr4wp6qv/v50 iTYYPLZ5DhbbRxC7MGsQdL8NjLMXgSdTKBrnrwtN+bytaGtzYBlSXcb/pJ/KnJyU Lo3FXmNhdUfGcy2CuU643+yeM2YLIX4CgZEIvv4YTsWRy9KlA33FRJ2vz5le7UYw eT/esOsC/qfA4NrKJryXXdkdObiQFcYDbQUPgp9srR/lSDhhTkun0NvVM9OPIbSQ O750m+qwp78EVOlbpLp00SYU4qpbW8RSAXf8oInVWTOhC01+semzVYRPpMaX6b0x WdrYHQ/RsFJBERrJcT02ZiOOehMhdZ44tyYS5POwSGPuqxLU/6sSrpJiXZw/zAWs 0q7UImrVERKeXSPegT7agWjTmpLtp06E1TbQdeJ8IwXH/v6tpoEk5yRh6JOPjqNX SrbH38O7ncvFOC4Z8qLpH/RuausDq4EPFw/NEzm7g7HFyw2JegQrZOYwuQUH0zwr HgyuYOsjRSOECkXRRQnIU0mHbeXrHAU1/tD7pGHkOyMrhbtyHXjeLRXAKIm5rbyr zHYL7Y1oBiCozeH3s5dLZyocm8ApQ5D0JsZEbeITB9yiMMGRPygSJHccRIlY63X2 xeIRylSA+l2qbytzmrJv =ORJs -----END PGP SIGNATURE----- --0qt3EE9wi45a2ZFX--