From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZWFV-00071U-EF for qemu-devel@nongnu.org; Tue, 16 Aug 2016 00:45:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZWFU-0005Yr-1Z for qemu-devel@nongnu.org; Tue, 16 Aug 2016 00:45:13 -0400 Date: Tue, 16 Aug 2016 14:45:31 +1000 From: David Gibson Message-ID: <20160816044530.GI14530@voom.fritz.box> References: <1470901008-3284-1-git-send-email-raji@linux.vnet.ibm.com> <1470901008-3284-6-git-send-email-raji@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hABqaeELJqnDDeDE" Content-Disposition: inline In-Reply-To: <1470901008-3284-6-git-send-email-raji@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v3 5/5] target-ppc: add vector permute right indexed instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rajalakshmi Srinivasaraghavan Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, benh@kernel.crashing.org --hABqaeELJqnDDeDE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 11, 2016 at 01:06:48PM +0530, Rajalakshmi Srinivasaraghavan wro= te: > Add vpermr instruction from ISA 3.0. >=20 > Signed-off-by: Rajalakshmi Srinivasaraghavan > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 23 +++++++++++++++++++++++ > target-ppc/translate/vmx-impl.c | 18 ++++++++++++++++++ > target-ppc/translate/vmx-ops.c | 1 + > 4 files changed, 43 insertions(+), 0 deletions(-) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index d1d9418..3c476c9 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -270,6 +270,7 @@ DEF_HELPER_5(vmsumubm, void, env, avr, avr, avr, avr) > DEF_HELPER_5(vmsummbm, void, env, avr, avr, avr, avr) > DEF_HELPER_5(vsel, void, env, avr, avr, avr, avr) > DEF_HELPER_5(vperm, void, env, avr, avr, avr, avr) > +DEF_HELPER_5(vpermr, void, env, avr, avr, avr, avr) > DEF_HELPER_4(vpkshss, void, env, avr, avr, avr) > DEF_HELPER_4(vpkshus, void, env, avr, avr, avr) > DEF_HELPER_4(vpkswss, void, env, avr, avr, avr) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 6bed3b6..a35355f 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -1126,6 +1126,29 @@ void helper_vperm(CPUPPCState *env, ppc_avr_t *r, = ppc_avr_t *a, ppc_avr_t *b, > *r =3D result; > } > =20 > +void helper_vpermr(CPUPPCState *env, ppc_avr_t *r, ppc_avr_t *a, ppc_avr= _t *b, > + ppc_avr_t *c) > +{ > + ppc_avr_t result; > + int i; > + > + VECTOR_FOR_INORDER_I(i, u8) { > + int s =3D c->u8[i] & 0x1f; > +#if defined(HOST_WORDS_BIGENDIAN) > + int index =3D 15 - (s & 0xf); > +#else > + int index =3D s & 0xf; > +#endif > + > + if (s & 0x10) { > + result.u8[i] =3D a->u8[index]; > + } else { > + result.u8[i] =3D b->u8[index]; > + } > + } > + *r =3D result; > +} > + > #if defined(HOST_WORDS_BIGENDIAN) > #define VBPERMQ_INDEX(avr, i) ((avr)->u8[(i)]) > #define VBPERMQ_DW(index) (((index) & 0x40) !=3D 0) > diff --git a/target-ppc/translate/vmx-impl.c b/target-ppc/translate/vmx-i= mpl.c > index 38f8ad7..feb10de 100644 > --- a/target-ppc/translate/vmx-impl.c > +++ b/target-ppc/translate/vmx-impl.c > @@ -750,6 +750,24 @@ static void gen_vmladduhm(DisasContext *ctx) > tcg_temp_free_ptr(rd); > } > =20 > +static void gen_vpermr(DisasContext *ctx) > +{ > + TCGv_ptr ra, rb, rc, rd; > + if (unlikely(!ctx->altivec_enabled)) { > + gen_exception(ctx, POWERPC_EXCP_VPU); > + return; > + } > + ra =3D gen_avr_ptr(rA(ctx->opcode)); > + rb =3D gen_avr_ptr(rB(ctx->opcode)); > + rc =3D gen_avr_ptr(rC(ctx->opcode)); > + rd =3D gen_avr_ptr(rD(ctx->opcode)); > + gen_helper_vpermr(cpu_env, rd, ra, rb, rc); > + tcg_temp_free_ptr(ra); > + tcg_temp_free_ptr(rb); > + tcg_temp_free_ptr(rc); > + tcg_temp_free_ptr(rd); > +} Why do you need this gen_vpermr() function while there isn't a matching gen_vperm()? > + > GEN_VAFORM_PAIRED(vmsumubm, vmsummbm, 18) > GEN_VAFORM_PAIRED(vmsumuhm, vmsumuhs, 19) > GEN_VAFORM_PAIRED(vmsumshm, vmsumshs, 20) > diff --git a/target-ppc/translate/vmx-ops.c b/target-ppc/translate/vmx-op= s.c > index 32bd533..ad72db5 100644 > --- a/target-ppc/translate/vmx-ops.c > +++ b/target-ppc/translate/vmx-ops.c > @@ -219,6 +219,7 @@ GEN_VXFORM_300_EO(vctzb, 0x01, 0x18, 0x1C), > GEN_VXFORM_300_EO(vctzh, 0x01, 0x18, 0x1D), > GEN_VXFORM_300_EO(vctzw, 0x01, 0x18, 0x1E), > GEN_VXFORM_300_EO(vctzd, 0x01, 0x18, 0x1F), > +GEN_VXFORM_300(vpermr, 0x1D, 0xFF), > =20 > #define GEN_VXFORM_NOA(name, opc2, opc3) \ > GEN_HANDLER(name, 0x04, opc2, opc3, 0x001f0000, PPC_ALTIVEC) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --hABqaeELJqnDDeDE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXsppqAAoJEGw4ysog2bOSVEIP/1gu1euifiU0Jy6DCmwtnHbS Vzjz6uwDjtLL9q44IcmEa4ZvhVRlXp7GbFDcCb04hDXFr2CviEI4RcGAxqJ845DN ZWOhm1buKSD5kqqyEVXaySURUzst3STkUbnbvwd0XwOgTkq01jbuwEY7cyXrSgQh cCsn0mXHjbP3YOBuhp5tC4SMdtPxOL6tumfOTJ6aF32ttHM98ulDDzyYbhCwEFqX nDO/BrzPC1Hh7RJwMd2gHkr39olI7gox6nMQqyCR+rtQiORqcPlxlhzSNbmLIkVt jNBxsNdm8YPhrhLfWW/BvMWs1rOGV94XGpTpfYbQKYGXftoFiEi7hpqtfm9s48I5 39HCsd+2or4+bn0s6yev8nVY8/mx5Hi2ku1xhlwkoyQYTXaUYLhBA2UcgB/aZyPX MVY0UyOWj95qLQZjcQjPHDX9iSDMiyl0lXG29YLEUVgbJ2uOWnS9LZ5UGFewSVrF bt/kkZP4UGyPhmPRKHsArc4jHtSLEMIF+ANXW3LbNK56AiMU2xaRZHo277H4SN/9 c0RRfVuKNedWsjr68yRWXNwQZ2mfvhW+IBGX2jYImed3U2gNT0yNAQNAQRyakwrS Zxymvh59nTB8fNzmLN1cfzpGiar1FXsDm/E1/gaNeNz+bRlyDcz1mbj/7BY22Vv+ zWfw6Tl0bwRTv30daQrc =oiql -----END PGP SIGNATURE----- --hABqaeELJqnDDeDE--