From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.8 v2 3/3] dmg: Move libbz2 code to dmg-bz2.so
Date: Tue, 16 Aug 2016 16:02:35 +0800 [thread overview]
Message-ID: <20160816080235.GA21679@al.usersys.redhat.com> (raw)
In-Reply-To: <1471334348-28747-4-git-send-email-famz@redhat.com>
On Tue, 08/16 15:59, Fam Zheng wrote:
> diff --git a/block/Makefile.objs b/block/Makefile.objs
> index fa4d8b8..141dec5 100644
> --- a/block/Makefile.objs
> +++ b/block/Makefile.objs
> @@ -40,6 +40,7 @@ gluster.o-libs := $(GLUSTERFS_LIBS)
> ssh.o-cflags := $(LIBSSH2_CFLAGS)
> ssh.o-libs := $(LIBSSH2_LIBS)
> archipelago.o-libs := $(ARCHIPELAGO_LIBS)
> -dmg.o-libs := $(BZIP2_LIBS)
> +block-obj-$(if $(CONFIG_BZIP2),m,n) += dmg-bz2.o
> +dmg-bz2.o-libs := $(BZIP2_LIBS)
> qcow.o-libs := -lz
> linux-aio.o-libs := -laio
> diff --git a/block/dmg-bz2.c b/block/dmg-bz2.c
> new file mode 100644
> index 0000000..a60e398
> --- /dev/null
> +++ b/block/dmg-bz2.c
> @@ -0,0 +1,62 @@
> +/*
> + * DMG bzip2 uncompression
> + *
> + * Copyright (c) 2004 Johannes E. Schindelin
> + * Copyright (c) 2016 Red Hat, Int.
Apparently I forgot to address Max's comments on v1. :(
Fam
prev parent reply other threads:[~2016-08-16 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 7:59 [Qemu-devel] [PATCH for-2.8 v2 0/3] block: Fix libbz2 library dependency regresssion Fam Zheng
2016-08-16 7:59 ` [Qemu-devel] [PATCH for-2.8 v2 1/3] scripts: Allow block module to not define BlockDriver Fam Zheng
2016-08-16 7:59 ` [Qemu-devel] [PATCH for-2.8 v2 2/3] module: Don't load the same module if requested multiple times Fam Zheng
2016-08-16 7:59 ` [Qemu-devel] [PATCH for-2.8 v2 3/3] dmg: Move libbz2 code to dmg-bz2.so Fam Zheng
2016-08-16 8:02 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816080235.GA21679@al.usersys.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).