From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bZZRT-0000Z3-Ia
	for qemu-devel@nongnu.org; Tue, 16 Aug 2016 04:09:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bZZRS-00047m-Is
	for qemu-devel@nongnu.org; Tue, 16 Aug 2016 04:09:47 -0400
Date: Tue, 16 Aug 2016 16:02:35 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160816080235.GA21679@al.usersys.redhat.com>
References: <1471334348-28747-1-git-send-email-famz@redhat.com>
	<1471334348-28747-4-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1471334348-28747-4-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.8 v2 3/3] dmg: Move libbz2 code to
 dmg-bz2.so
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

On Tue, 08/16 15:59, Fam Zheng wrote:
> diff --git a/block/Makefile.objs b/block/Makefile.objs
> index fa4d8b8..141dec5 100644
> --- a/block/Makefile.objs
> +++ b/block/Makefile.objs
> @@ -40,6 +40,7 @@ gluster.o-libs     := $(GLUSTERFS_LIBS)
>  ssh.o-cflags       := $(LIBSSH2_CFLAGS)
>  ssh.o-libs         := $(LIBSSH2_LIBS)
>  archipelago.o-libs := $(ARCHIPELAGO_LIBS)
> -dmg.o-libs         := $(BZIP2_LIBS)
> +block-obj-$(if $(CONFIG_BZIP2),m,n) += dmg-bz2.o
> +dmg-bz2.o-libs     := $(BZIP2_LIBS)
>  qcow.o-libs        := -lz
>  linux-aio.o-libs   := -laio
> diff --git a/block/dmg-bz2.c b/block/dmg-bz2.c
> new file mode 100644
> index 0000000..a60e398
> --- /dev/null
> +++ b/block/dmg-bz2.c
> @@ -0,0 +1,62 @@
> +/*
> + * DMG bzip2 uncompression
> + *
> + * Copyright (c) 2004 Johannes E. Schindelin
> + * Copyright (c) 2016 Red Hat, Int.

Apparently I forgot to address Max's comments on v1. :(

Fam