From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZZku-0001cp-7Z for qemu-devel@nongnu.org; Tue, 16 Aug 2016 04:29:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZZkp-0007Sf-Hs for qemu-devel@nongnu.org; Tue, 16 Aug 2016 04:29:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZZkp-0007Ry-C6 for qemu-devel@nongnu.org; Tue, 16 Aug 2016 04:29:47 -0400 Date: Tue, 16 Aug 2016 09:29:40 +0100 From: "Daniel P. Berrange" Message-ID: <20160816082940.GA25115@redhat.com> Reply-To: "Daniel P. Berrange" References: <1471270945-19975-1-git-send-email-berrange@redhat.com> <20160815144611.482797.13897@ex-std-node742.prod.rhcloud.com> <20160816012140.GB15442@al.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160816012140.GB15442@al.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH v10 00/11] Provide a QOM-based authorization API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, armbru@redhat.com, mreitz@redhat.com, marcandre.lureau@gmail.com, pbonzini@redhat.com, afaerber@suse.de On Tue, Aug 16, 2016 at 09:21:40AM +0800, Fam Zheng wrote: > On Mon, 08/15 07:46, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > > /tmp/qemu-test/src/util/authz-pam.c:26:32: warning: security/pam_appl.h: No such file or directory > > Hi Daniel, > > I think there is an unfortunate CONFIG_ var collision you probably want to > avoid: > > $ git grep CONFIG_PAM > configure: echo "CONFIG_PAM=y" >> $config_host_mak > default-configs/i386-softmmu.mak:CONFIG_PAM=y > default-configs/x86_64-softmmu.mak:CONFIG_PAM=y Fun, those don't appear to have been used anywhere. In fact I see 4 config options in default-configs are appear unused $ for i in `grep -h -E '^CONFIG' default-configs/* | sed -e 's/=.*//' | sort | uniq` do echo -n "$i: " git grep $i | grep -v default-configs | wc -l done | grep ": 0" CONFIG_IPMI_EXTERN: 0 CONFIG_ISA_MMIO: 0 CONFIG_PAM: 0 CONFIG_PIIX_PCI: 0 so I'll send a patch to delete those Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|