From: no-reply@patchew.org
To: michael@walle.cc
Cc: famz@redhat.com, riku.voipio@iki.fi, tommusta@gmail.com,
qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP
Date: Tue, 16 Aug 2016 07:50:48 -0700 (PDT) [thread overview]
Message-ID: <20160816145044.482797.52654@ex-std-node742.prod.rhcloud.com> (raw)
In-Reply-To: <1471354850-5549-1-git-send-email-michael@walle.cc>
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Message-id: 1471354850-5549-1-git-send-email-michael@walle.cc
Subject: [Qemu-devel] [PATCH] linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1471354850-5549-1-git-send-email-michael@walle.cc -> patchew/1471354850-5549-1-git-send-email-michael@walle.cc
Switched to a new branch 'test'
b0ee12f linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP
=== OUTPUT BEGIN ===
Checking PATCH 1/1: linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP...
ERROR: braces {} are necessary for all arms of this statement
#22: FILE: linux-user/elfload.c:745:
+ do { if ((cpu->env.insns_flags2 & flag) == flag) \
[...]
total: 1 errors, 0 warnings, 9 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
next prev parent reply other threads:[~2016-08-16 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 13:40 [Qemu-devel] [PATCH] linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP Michael Walle
2016-08-16 14:50 ` no-reply [this message]
2016-09-20 2:23 ` David Gibson
2016-09-20 6:55 ` Michael Walle
2016-09-20 13:12 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160816145044.482797.52654@ex-std-node742.prod.rhcloud.com \
--to=no-reply@patchew.org \
--cc=agraf@suse.de \
--cc=famz@redhat.com \
--cc=michael@walle.cc \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=tommusta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).