From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block jobs: Improve error message for missing job ID
Date: Wed, 17 Aug 2016 09:28:09 +0100 [thread overview]
Message-ID: <20160817082809.GA16122@stefanha-x1.localdomain> (raw)
In-Reply-To: <1471356130-9551-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 463 bytes --]
On Tue, Aug 16, 2016 at 04:02:10PM +0200, Kevin Wolf wrote:
> If a block job is started with a node name rather than a device name and
> no explicit job ID is passed, it was reported that '' isn't a
> well-formed ID. Which is correct, but we can make the message a little
> bit nicer.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> blockjob.c | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-17 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 14:02 [Qemu-devel] [PATCH] block jobs: Improve error message for missing job ID Kevin Wolf
2016-08-16 14:10 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2016-08-16 14:11 ` Alberto Garcia
2016-08-17 8:28 ` Stefan Hajnoczi [this message]
2016-08-17 9:08 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160817082809.GA16122@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).