[Qemu-devel] [PATCH] block jobs: Improve error message for missing job ID

[Qemu-devel] [PATCH] block jobs: Improve error message for missing job ID

[Kevin Wolf]

If a block job is started with a node name rather than a device name and
no explicit job ID is passed, it was reported that '' isn't a
well-formed ID. Which is correct, but we can make the message a little
bit nicer.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 blockjob.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/blockjob.c b/blockjob.c
index a5ba3be..a167f96 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -132,6 +132,10 @@ void *block_job_create(const char *job_id, const BlockJobDriver *driver,
 
     if (job_id == NULL) {
         job_id = bdrv_get_device_name(bs);
+        if (!*job_id) {
+            error_setg(errp, "An explicit job ID is required for this node");
+            return NULL;
+        }
     }
 
     if (!id_wellformed(job_id)) {
-- 
1.8.3.1

Re: [Qemu-devel] [Qemu-block] [PATCH] block jobs: Improve error message for missing job ID

[Jeff Cody]

On Tue, Aug 16, 2016 at 04:02:10PM +0200, Kevin Wolf wrote:
> If a block job is started with a node name rather than a device name and
> no explicit job ID is passed, it was reported that '' isn't a
> well-formed ID. Which is correct, but we can make the message a little
> bit nicer.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  blockjob.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/blockjob.c b/blockjob.c
> index a5ba3be..a167f96 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -132,6 +132,10 @@ void *block_job_create(const char *job_id, const BlockJobDriver *driver,
>  
>      if (job_id == NULL) {
>          job_id = bdrv_get_device_name(bs);
> +        if (!*job_id) {
> +            error_setg(errp, "An explicit job ID is required for this node");
> +            return NULL;
> +        }
>      }
>  
>      if (!id_wellformed(job_id)) {
> -- 
> 1.8.3.1
> 
> 

Reviewed-by: Jeff Cody <jcody@redhat.com>

Re: [Qemu-devel] [Qemu-block] [PATCH] block jobs: Improve error message for missing job ID

[Alberto Garcia]

On Tue 16 Aug 2016 04:02:10 PM CEST, Kevin Wolf wrote:
> If a block job is started with a node name rather than a device name and
> no explicit job ID is passed, it was reported that '' isn't a

"it was" ?

> well-formed ID. Which is correct, but we can make the message a little
> bit nicer.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

Re: [Qemu-devel] [Qemu-block] [PATCH] block jobs: Improve error message for missing job ID

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

On Tue, Aug 16, 2016 at 04:02:10PM +0200, Kevin Wolf wrote:
> If a block job is started with a node name rather than a device name and
> no explicit job ID is passed, it was reported that '' isn't a
> well-formed ID. Which is correct, but we can make the message a little
> bit nicer.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  blockjob.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] [PATCH] block jobs: Improve error message for missing job ID

[Kevin Wolf]

Am 16.08.2016 um 16:02 hat Kevin Wolf geschrieben:
> If a block job is started with a node name rather than a device name and
> no explicit job ID is passed, it was reported that '' isn't a
> well-formed ID. Which is correct, but we can make the message a little
> bit nicer.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Applied to block-next.

Kevin