From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ba1Mf-0005dY-2P for qemu-devel@nongnu.org; Wed, 17 Aug 2016 09:58:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ba1Mb-00006f-5o for qemu-devel@nongnu.org; Wed, 17 Aug 2016 09:58:41 -0400 Date: Wed, 17 Aug 2016 14:58:33 +0100 From: Stefan Hajnoczi Message-ID: <20160817135833.GA8753@stefanha-x1.localdomain> References: <1471265656-11227-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: <1471265656-11227-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] virtio: fix VirtQueue->inuse field List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Cornelia Huck , Fam Zheng , "Michael S. Tsirkin" , qemu-stable@nongnu.org, Peter Maydell , marc.deslauriers@ubuntu.com --opJtzjQTFsWo+cga Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 15, 2016 at 01:54:14PM +0100, Stefan Hajnoczi wrote: > The VirtQueue->inuse field is not always updated correctly. These patche= s fix > it. >=20 > Originally this series was called "virtio-balloon: fix stats vq migration= " but > Ladi Prosek posted a nicer fix called "balloon: Fix failure of updating g= uest > memory status". I dropped the virtio-balloon patches. >=20 > Changes from previous series: > * Missing comma in error formatting [Fam] > * virtio_descard() -> virtio_discard() [Michael] > * Multi-line comment style [Cornelia] >=20 > Stefan Hajnoczi (2): > virtio: recalculate vq->inuse after migration > virtio: decrement vq->inuse in virtqueue_discard() >=20 > hw/virtio/virtio.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) I should mention this is for QEMU 2.7. These fixes are needed if the CVE-2016-5403 patch has been applied. Without these patches any device that holds VirtQueueElements across live migration will terminate with a "Virtqueue size exceeded" error message. virtio-balloon and virtio-scsi are affected. virtio-blk probably too but I haven't tested it. Stefan --opJtzjQTFsWo+cga Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXtG2JAAoJEJykq7OBq3PItwoH/Rvjt+McuOI+AnyQj9PEZfZJ JptHdSB7DMDvBJ+d01E/3L9USsM/Agl9W3i6l8f5g/2ijf1RGqnvDWG2Yr1aVKPn uiPI2bWHNMkNe7lGXCIfB6wsWIHv/hWYdx6DosXW9Q67UX752PbTm6G1/DNSEVmC XwDJGSYpeHBWNSj6gWFSS8U2wep9fqPjqxq+ymb74D16y0iVkaOFil4jDPiUJ8oK W50G/sFchXHZJWsun5670kEP4VMNbF4diButaANbou4XIZ6dW3wjPKOpTeBthAcM BRTGukHIwavc6h+loeNaRLrunWiqyl1OGQGUNCSqqPVIlOLKCabg5TqHIpBlkGw= =vUEU -----END PGP SIGNATURE----- --opJtzjQTFsWo+cga--