Re: [Qemu-devel] [PATCH v4 0/2] trace: Simplify late initialization

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]

On Fri, Aug 12, 2016 at 05:33:35PM +0200, Lluís Vilanova wrote:
> Removes the need for 'trace_events_dstate_init' and does a little cleanup in how
> state values are modified (to avoid implicit conversions from bool).
> 
> Changes in v2
> =============
> 
> * Fix late-init state value [Daniel P. Berrange].
> 
> Changes in v3
> =============
> 
> * Avoid implicit conversions from bool to integers (second patch) [Daniel
>   P. Berrange].
> 
> Changes in v4
> =============
> 
> * Correctly implement idempotent state changes.
> * Clarify when state changes are idempotent [Daniel P. Berrange].
> 
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> 
> Lluís Vilanova (2):
>       trace: Remove 'trace_events_dstate_init'
>       trace: Avoid implicit bool->integer conversions
> 
> 
>  stubs/trace-control.c  |   22 ++++++++++++++++++++--
>  trace/control-target.c |   34 ++++++++++++++++++++++++++++++++--
>  trace/control.c        |   23 ++++++++++-------------
>  trace/control.h        |    3 +++
>  trace/event-internal.h |    1 +
>  5 files changed, 66 insertions(+), 17 deletions(-)
> 
> 
> To: qemu-devel@nongnu.org
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: 'Daniel P. Berrange' <berrange@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>

I will wait for Daniel Berrange to review before merging since he had
comments on previous revisions.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]