qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Roman Kagan <rkagan@virtuozzo.com>
Cc: qemu-devel@nongnu.org, "Denis V. Lunev" <den@openvz.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] virtio-balloon: assorted fixes
Date: Fri, 19 Aug 2016 14:41:29 +0100	[thread overview]
Message-ID: <20160819134129.GC20309@stefanha-x1.localdomain> (raw)
In-Reply-To: <1471544874-26996-1-git-send-email-rkagan@virtuozzo.com>

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

On Thu, Aug 18, 2016 at 09:27:50PM +0300, Roman Kagan wrote:
> This patchset addresses a few problems discovered when analyzing aborts
> of (an older version of) QEMU with backported commit
> afd9096eb1882f23929f5b5c177898ed231bac66 "virtio: error out if guest
> exceeds virtqueue size".  Those problems are present in master, too,
> except that they don't trigger an abort and are thus not as easy to
> notice.
> 
> 
> Roman Kagan (4):
>   virtio: assert on ->inuse underflow
>   virtio-balloon: make stats virtqueue length 1
>   virtio-balloon: don't restart stats timer in callback
>   virtio-balloon: keep collecting stats on save/restore
> 
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> 
>  hw/virtio/virtio-balloon.c         | 49 +++++++++++++++++++++-----------------
>  hw/virtio/virtio.c                 |  3 ++-
>  include/hw/virtio/virtio-balloon.h |  1 +
>  3 files changed, 30 insertions(+), 23 deletions(-)

Please see these related patches on the mailing list:

1. [PATCH v3] balloon: Fix failure of updating guest memory status

   This addresses the virtio-balloon stats virtqueue hang after
   migration.

2. [PATCH 0/2] virtio: fix VirtQueue->inuse field

   Fixes to update virtio.c in code paths where it currently becomes
   inconsistent.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      parent reply	other threads:[~2016-08-19 13:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18 18:27 [Qemu-devel] [PATCH 0/4] virtio-balloon: assorted fixes Roman Kagan
2016-08-18 18:27 ` [Qemu-devel] [PATCH 1/4] virtio: assert on ->inuse underflow Roman Kagan
2016-08-18 18:27 ` [Qemu-devel] [PATCH 2/4] virtio-balloon: make stats virtqueue length 1 Roman Kagan
2016-08-19 10:05   ` Ladi Prosek
2016-08-19 11:04     ` Roman Kagan
2016-08-19 13:44   ` Stefan Hajnoczi
2016-08-19 14:38     ` Roman Kagan
2016-08-18 18:27 ` [Qemu-devel] [PATCH 3/4] virtio-balloon: don't restart stats timer in callback Roman Kagan
2016-08-18 18:27 ` [Qemu-devel] [PATCH 4/4] virtio-balloon: keep collecting stats on save/restore Roman Kagan
2016-08-19  9:57   ` Ladi Prosek
2016-08-19 11:37     ` Roman Kagan
2016-08-19 12:08       ` Ladi Prosek
2016-08-19 14:45         ` Roman Kagan
2016-08-19 19:01           ` Ladi Prosek
2016-08-19 13:41 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160819134129.GC20309@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=den@openvz.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkagan@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).