From: Stefan Hajnoczi <stefanha@gmail.com>
To: Reda Sallahi <fullmanet@gmail.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Fam Zheng <famz@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3] qemu-img: change opening method for the output in dd
Date: Mon, 22 Aug 2016 07:39:42 -0400 [thread overview]
Message-ID: <20160822113942.GA28679@stefanha-x1.localdomain> (raw)
In-Reply-To: <20160819190557.GA8418@vps308710.ovh.net>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Fri, Aug 19, 2016 at 09:06:08PM +0200, Reda Sallahi wrote:
> On Tue, Aug 16, 2016 at 12:09:06PM +0100, Stefan Hajnoczi wrote:
> > On Mon, Aug 15, 2016 at 02:11:49PM +0200, Reda Sallahi wrote:
> > > + blk2 = blk_new_open(image_opts ? NULL : out.filename,
> > > + NULL, qoptions, BDRV_O_RDWR, NULL);
> >
> > This code duplicates a subset of img_open(). Why can't you use
> > img_open() or at least img_open_opts()/img_open_file()?
>
> If I used img_open() here (or img_open_opts()/img_open_file() for that
> matter) it would have written on stderr that the file couldn't be opened
> here even though in this case it's not error if we can create the output
> image and open it later on.
Then img_open() should be extended so the caller can suppress the error
message or gets a Error object instead of output to stderr.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-08-22 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 12:11 [Qemu-devel] [PATCH v3] qemu-img: change opening method for the output in dd Reda Sallahi
2016-08-16 11:09 ` Stefan Hajnoczi
2016-08-19 19:06 ` Reda Sallahi
2016-08-22 11:39 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822113942.GA28679@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=fullmanet@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).