From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, jasowang@redhat.com, berrange@redhat.com,
ashijeetacharya@gmail.com, crobinso@redhat.com,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH for-2.7 0/2] Fix net socket connect regressions
Date: Tue, 23 Aug 2016 13:45:35 +0400 [thread overview]
Message-ID: <20160823094537.8782-1-marcandre.lureau@redhat.com> (raw)
Hi,
Commit 7e8449594c929 introduced multiple regressions. The most
important is that the socket is actually not the one connected, due to
wrong usage of socket_connect(). I fixed that along with some leak
fixes, that could eventually be splitted.
Secondly, connect is no longer non-blocking. The second patch is my
attempt to fix it.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1368447
Please review asap
Marc-André Lureau (2):
net: fix socket connect
net: make socket connect non-blocking again
net/socket.c | 102 ++++++++++++++++++++++++++++++++++-------------------------
1 file changed, 59 insertions(+), 43 deletions(-)
--
2.9.0
next reply other threads:[~2016-08-23 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 9:45 Marc-André Lureau [this message]
2016-08-23 9:45 ` [Qemu-devel] [PATCH for-2.7 1/2] net: fix socket connect Marc-André Lureau
2016-08-23 9:45 ` [Qemu-devel] [PATCH for-2.7 2/2] net: make socket connect non-blocking again Marc-André Lureau
2016-08-23 10:43 ` Cao jin
2016-08-23 13:13 ` Daniel P. Berrange
2016-08-23 13:33 ` Marc-André Lureau
2016-08-30 12:07 ` [Qemu-devel] [PATCH for-2.7 0/2] Fix net socket connect regressions Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823094537.8782-1-marcandre.lureau@redhat.com \
--to=marcandre.lureau@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=berrange@redhat.com \
--cc=crobinso@redhat.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).