From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bc8HD-0005Po-PG for qemu-devel@nongnu.org; Tue, 23 Aug 2016 05:45:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bc8H8-00057f-Jh for qemu-devel@nongnu.org; Tue, 23 Aug 2016 05:45:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bc8H8-00057S-D0 for qemu-devel@nongnu.org; Tue, 23 Aug 2016 05:45:42 -0400 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Tue, 23 Aug 2016 13:45:35 +0400 Message-Id: <20160823094537.8782-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH for-2.7 0/2] Fix net socket connect regressions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, jasowang@redhat.com, berrange@redhat.com, ashijeetacharya@gmail.com, crobinso@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Hi, Commit 7e8449594c929 introduced multiple regressions. The most important is that the socket is actually not the one connected, due to wrong usage of socket_connect(). I fixed that along with some leak fixes, that could eventually be splitted. Secondly, connect is no longer non-blocking. The second patch is my attempt to fix it. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D1368447 Please review asap Marc-Andr=C3=A9 Lureau (2): net: fix socket connect net: make socket connect non-blocking again net/socket.c | 102 ++++++++++++++++++++++++++++++++++-------------------= ------ 1 file changed, 59 insertions(+), 43 deletions(-) --=20 2.9.0